← Back to issue list

build(deps): Remove comment regarding setuptools warning

View original Github issue

Metadata

Project
rockcraft
Number
#1300
Type
pull request
State
merged
Author
lengau
Labels
documentation
Created
Updated
Closed

Current evaluation

Merged. Removed the setuptools warning comment and the unused sphinxcontrib-details-directive dependency to resolve lint errors. Approved by three reviewers with passing CI checks.

Suggested action:

No scores available.

Issue body

Removed comment about setuptools warning in dependencies. Drive-by: removes unused sphinxcontrib-details-directive that caused lint errors --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Removed the setuptools warning comment and the unused sphinxcontrib-details-directive dependency to resolve lint errors. Approved by three reviewers with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a documentation update removing a setuptools warning comment from dependencies. The change also eliminated the unused sphinxcontrib-details-directive package to resolve lint errors.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#877 build(deps): update bugfixes (main) craft-parts merged Merged automated dependency updates for pyright, sphinx-design, sphinx-tabs, and sphinxcontrib-qthelp. Approved by two reviewers, passed CI checks, and merged via automerge to main.
75%
#105 build(deps): constrain setuptools-scm due to cyclic dependency debcraft merged Merged to constrain setuptools-scm and resolve a cyclic dependency. Approved by two reviewers and passed most CI checks despite one failing OSV-scanner. The change updates two files, adding 10 lines and removing 430.
74%
#110 build(deps): unpin setuptools-scm debcraft merged Merged unpinning of the setuptools-scm dependency after the upstream bug was resolved. Approved by two reviewers and passed CI checks, updating version constraints across two files.
73%
#1493 build(deps): update dependencies charmcraft merged Merged pull request updating project dependencies. Approved by two reviewers, the maintainer addressed comments on unused packages and clarified that CI failures resulted from an external issue.
73%
#306 build(deps): constrain setuptools-scm due to cyclic dependency imagecraft merged Merged a dependency update constraining setuptools-scm to resolve a cyclic dependency. Approved by two reviewers and passed most CI checks before being merged.
73%
#6123 build(deps): constrain setuptools-scm due to cyclic dependency snapcraft merged Merged to constrain setuptools-scm and resolve a cyclic dependency. Approved by two reviewers, passed CI, and applied with a six-line addition across two files.
73%
#2615 build(deps): unpin setuptools-scm charmcraft merged Merged unpinning of setuptools-scm after upstream bug resolution. Approved by two reviewers, the change modified two files with a net reduction of five lines. CI passed despite non-blocking type warnings, successfully removing the dependency constraint.
72%
#1501 build(docs): update and clean docs dependencies craft-parts merged Merged following approval by three reviewers. Updated and cleaned documentation dependencies, removing sphinx-pydantic in favor of pydantic-kitbash. All required CI checks passed.
72%
#4848 style: remove pylint comments snapcraft merged Merged cleanup removing remaining pylint comments. Approved by two reviewers, passed CI checks, and updated two files with minimal changes.
72%
#526 build(deps): update dependency setuptools to v75 craft-application merged Merged automated dependency update upgrading setuptools from v74.1.3 to v75.1.0. Approved by two reviewers, passed CI checks, and modified a single file.
71%