← Back to issue list

build(deps): Remove comment regarding setuptools warning

View original Github issue

Metadata

Project
rockcraft
Number
#1300
Type
pull request
State
merged
Author
lengau
Labels
documentation
Created
Updated
Closed

Current evaluation

Merged cleanup PR (+3/-20, 3 files): removed an outdated comment about the setuptools warning from the docs dependencies and dropped the unused sphinxcontrib-details-directive that caused lint errors. Approved by 3 reviewers with no unresolved comments.

Resolution: closed resolved

Reason: The pull request itself was merged into rockcraft after approval from three maintainer reviewers. It removed the stale setuptools warning comment plus the unused sphinxcontrib-details-directive dependency flagged by lint, resolving the lint / files check failure.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Removed comment about setuptools warning in dependencies. Drive-by: removes unused sphinxcontrib-details-directive that caused lint errors --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged cleanup PR (+3/-20, 3 files): removed an outdated comment about the setuptools warning from the docs dependencies and dropped the unused sphinxcontrib-details-directive that caused lint errors. Approved by 3 reviewers with no unresolved comments.
stealth/space-bunny-alpha — closed resolved Merged docs cleanup removing the setuptools warning comment and unused sphinxcontrib-details-directive dependency.
qwen/qwen3.6-35b-a3b — — Merged. Removed the setuptools warning comment and the unused sphinxcontrib-details-directive dependency to resolve lint errors. Approved by three reviewers with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a documentation update removing a setuptools warning comment from dependencies. The change also eliminated the unused sphinxcontrib-details-directive package to resolve lint errors.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#298 build(deps): update dependency setuptools to v82 (main) - autoclosed imagecraft closed Renovate's setuptools<82.1 PR was closed unmerged after a maintainer proposed removing obsolete sphinxcontrib-details-directive and loosening the setuptools cap.
72%