← Back to issue list

style: resolve linting issues

View original Github issue

Metadata

Project
rockcraft
Number
#1322
Type
pull request
State
closed
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Closed without merging. Addressed linting issues ISC004, INP001, and PTH118/120 across five files but was abandoned due to unresolved review comments and a failing source-spread-tests CI check.

Suggested action:

No scores available.

Issue body

This PR fixes several linting issues including ISC004, INP001, and PTH118/120.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merging. Addressed linting issues ISC004, INP001, and PTH118/120 across five files but was abandoned due to unresolved review comments and a failing source-spread-tests CI check.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 5
Confidence: 90
needs review Resolves linting issues (ISC004, INP001, PTH118/120) across 5 files. Currently pending maintainer review with 7 unresolved comments and one failing CI check (source-spread-tests).
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Resolves linting issues (ISC004, INP001, PTH118/120) across 5 files. Currently pending maintainer review with 8 unresolved comments and passing CI.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Resolves linting issues (ISC004, INP001, PTH118/120) across 5 files. Currently pending maintainer review with 7 unresolved comments. CI shows passing minimum dependency and lint checks, but fast tests and schema diffs are failing.

Update history

Date Change
closed
updated
updated
created

Related issues

Issue Project State Summary Similarity
#5 style(lint): fix linting issues starflow merged Merged after approval. Resolved linting issues by modifying one file with three additions and three deletions. No unresolved comments or CI checks were present.
78%
#2222 style: fix linting issues charmcraft merged Merged following approval by two reviewers. Resolved linting issues across three files with minor style adjustments (+8/-9 lines). No review comments or CI checks were required.
76%
#20 style: fix linting issues craft-artifacts merged Merged after passing all CI checks and receiving approval from two reviewers. The change resolves linting issues across four files with a +11/-5 line diff, updating code style compliance.
75%
#264 lint: format with ruff and fix ruff linting errors rockcraft closed Closed without merging. The ruff formatting and linting fixes were abandoned due to zero reviewer engagement and a pending dependency on issue #263.
74%
#239 style(lint): autoformat starbase merged Merged after approval. Applied automated linting to a single file, adjusting one line. The maintainer requested the merge post-review, completed without CI checks or unresolved comments.
72%
#77 lint: fix linting issues with up-to-date linters craft-store merged Merged a maintainer-submitted pull request resolving linting errors from updated linter versions. Approved by one reviewer, passed CI, and modified 11 files (+40/-24 lines).
72%
#977 style(lint): go all-in on ty craft-providers closed Closed without merge. The PR introduced minor lint changes but remained unreviewed with two unresolved comments and failing CI checks, indicating it was abandoned.
72%
#567 ci: fix linter issues craft-parts merged Merged fix for CI linter issues across four files (+14/-6 lines). Approved by one reviewer and passed all CI checks before integration.
71%
#142 lint: fix linting issues with newer linters craft-cli merged Merged after reviewer approval and passing CI checks. Resolves linting failures caused by updated linter versions across five files. Ubuntu 18.04 GitHub Actions test failures were addressed separately in pull request #144.
70%