← Back to issue list

build: bump rustc/cargo to 1.91

View original Github issue

Metadata

Project
rockcraft
Number
#1326
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

PR #1326 merged (commit 0d78b71a), bumping rustc/cargo to 1.91 in CI, copying the rustup-style install used by Snapcraft and Charmcraft. Merged with 2 approvals despite unrelated failing checks.

Resolution: closed resolved

Reason: The pull request was merged into main as commit 0d78b71a, updating the workflow to install rustc/cargo 1.91 the same way Snapcraft and Charmcraft do. Two reviewers approved it; the remaining red checks (source-spread-tests, Security scan / OSV-scanner) are unrelated toolchain jobs and did not block the merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Copies the way Snapcraft and Charmcraft install the newer cargo --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes. --- <sub>Stack created with <a href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1326 merged (commit 0d78b71a), bumping rustc/cargo to 1.91 in CI, copying the rustup-style install used by Snapcraft and Charmcraft. Merged with 2 approvals despite unrelated failing checks.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#1326 (commit 0d78b71a), bumping rustc and Cargo to 1.91 using the installation approach from Snapcraft and Charmcraft.
qwen/qwen3.6-35b-a3b — — Merged changes bumping rustc and cargo to version 1.91, adopting the installation method used by Snapcraft and Charmcraft. Approved by two reviewers and passed CI checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 95
needs review Bumps rustc and cargo to version 1.91, aligning installation methods with Snapcraft and Charmcraft. Currently approved by two reviewers with zero unresolved comments and passing CI checks.

Update history

Date Change
updated
updated
updated
created

Related work

  • Related To: canonical/snapcraft (confidence 60%)

    PR body states the new rust 1.91 installation steps were copied from Snapcraft (and Charmcraft) workflows.

  • Related To: canonical/charmcraft (confidence 55%)

    Same source referenced in the PR body for the newer cargo install method.

Related issues

Issue Project State Summary Similarity
#235 fix(build): update rustc and cargo imagecraft merged Merged in canonical/imagecraft#235 (commit 8ddd13b), updating rustc and cargo for maturin 1.10 compatibility; all reported CI checks passed.
73%