← Back to issue list

docs: fix version string for 1.x

View original Github issue

Metadata

Project
rockcraft
Number
#1335
Type
pull request
State
merged
Author
jahn-junior
Labels
Created
Updated
Closed

Current evaluation

Merged to a hotfix branch, fixing 1.x documentation version strings to show major.minor locally and in branches, with latest showing dev. Approved by three reviewers and passed all CI checks after clarifying its scope relative to PR 1334.

Suggested action:

No scores available.

Issue body

With this change, all local, PR, and branch builds will show the major and minor version in the docs title. The only exception is the 'latest' branch build, which will show 'dev' as the version. This was brought about by the simplification of our RTD version slugs. --- - [X] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [X] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [X] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to a hotfix branch, fixing 1.x documentation version strings to show major.minor locally and in branches, with latest showing dev. Approved by three reviewers and passed all CI checks after clarifying its scope relative to PR 1334.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 5
Confidence: 95
needs review Fixes documentation version string display for 1.x builds by adjusting RTD slug handling. Approved by two reviewers, targets a hotfix branch, and has no unresolved comments.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Updates documentation build configuration to correctly display major/minor version strings in titles, targeting a hotfix branch. Approved by two reviewers, zero unresolved comments, and ready for merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Fixes documentation version string display for 1.x releases and the latest branch. Approved by one reviewer, author clarified it targets a hotfix branch. Currently awaiting final maintainer review and merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 85
needs review Fixes documentation version string display for 1.x builds by adjusting RTD slug handling. Currently approved by one reviewer but has one unresolved comment questioning the target branch and overlap with another PR.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 85
needs review Documentation fix updating version string display in docs title. Approved by one reviewer but has one unresolved comment asking about target branch and relation to PR #1334.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 0
Confidence: 95
needs review Updates documentation build configuration to correctly display major/minor version strings in titles for local, PR, and branch builds, except the latest branch which shows 'dev'. Currently awaiting review.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 5
Confidence: 85
needs review Updates documentation version string display to show major/minor versions for builds, while latest shows dev. Currently pending initial maintainer review with no CI checks run.

Update history

Date Change
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#2832 docs: fix version string for 4.x charmcraft merged Merged. Updated documentation to correctly display major and minor version strings for local, PR, and branch builds, reserving 'dev' for the latest branch. Approved by one reviewer with all CI checks passing.
84%
#588 docs: fix version in title starbase merged Merged documentation update correcting version display in titles. Builds now show major and minor versions, with latest displaying dev. Approved by two reviewers and passed all CI checks.
81%
#2787 docs: fix versioning logic charmcraft merged Merged. Fixes branch-based documentation build versioning logic by correcting version name generation. Passed all CI checks and received reviewer approval.
80%
#6173 docs: format doc version as major.minor snapcraft merged Merged a documentation update that formats version strings as major.minor. Approved by two reviewers, passed CI checks, and integrated with a three-line change.
78%
#1334 docs: fix version string on latest rockcraft merged Merged documentation fix updating version string display. Local, PR, and branch builds now show major and minor versions, while the latest branch displays dev. Aligns with simplified RTD version slugs.
78%
#2831 docs: fix version string for 3.x charmcraft merged Merged docs fix for 3.x version string. Local, PR, and branch builds now show major and minor version in the title, while latest shows 'dev'. Aligns with simplified Read the Docs slugs. Approved and merged.
78%
#6313 docs: fix version numbering snapcraft merged Merged documentation update fixing version numbering by applying patch from #6295. Approved by reviewer, passed CI checks, and successfully merged with 7 lines changed across one file.
78%
#2649 docs: format doc version as major.minor charmcraft merged Merged a documentation update that formats version strings as major.minor. Approved by three reviewers and merged despite a failing typecheck CI, modifying a single file.
77%
#97 docs: changelog for 1.1.3 craft-archives merged Merged documentation update adding the changelog for version 1.1.3. Approved by one reviewer, passed CI checks, and introduced no code changes or coverage impact. Successfully merged into main.
77%
#6295 docs: fix version numbering snapcraft merged Merged documentation fix aligning ReadTheDocs version numbering with the new branch-based release policy. Incorporated reviewer feedback to refactor conditional logic and add comments. Updated version detection for main, hotfix, and PR branches.
76%