refactor: drop unused error classes
Metadata
Current evaluation
⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.
Removes 3 unused error classes and a helper method from rockcraft/errors.py. All CI checks passing, no review comments.
Suggested action: needs review
Reason: Clean dead-code removal (+0/-20 lines, 1 file) with all CI checks passing. Verified via grep that RockcraftInitError, ProjectLoadError, and PartsLifecycleError are only defined in errors.py and never referenced elsewhere (the test file uses craft_application.errors.PartsLifecycleError, not rockcraft's). Ready for maintainer review.
Evaluated by: mr-cal-bot
Impact:
5
Quick Win:
4
Complexity:
5
Confidence:
90
Actionability:
80
Issue body
Removes `RockcraftInitError`, `PartsLifecycleError` (and its `from_parts_error` helper), and `ProjectLoadError` from `rockcraft/errors.py`. None are raised or referenced anywhere in the codebase.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
5
Quick Win:
4
Complexity:
5
Confidence:
90
Actionability:
80
|
needs review | Removes 3 unused error classes and a helper method from rockcraft/errors.py. All CI checks passing, no review comments. | |
| ~deepseek/deepseek-pro-latest |
Impact:
10
Quick Win:
4
Complexity:
8
Confidence:
70
Actionability:
40
|
keep open | Removes RockcraftInitError, PartsLifecycleError (with from_parts_error), and ProjectLoadError from rockcraft/errors.py; leaves unused PartsError import, so lint/files fails. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #61 feat: refactor all errors into reusable module | rockcraft | merged | Merged PR #61 consolidated Rockcraft's custom exceptions into a reusable rockcraft/errors.py module via commit 75d124b9. |