chore: Fixes for 26.04 12-factor extensions. /tmp and init templates.
Metadata
Current evaluation
Fixes /tmp staging for 12-factor extensions and updates init templates. Approved by 2 reviewers but has 1 unresolved comment requesting rebase onto hotfix/1.21.
Suggested action: close superseded
Reason: PR #1399 has the identical title 'chore: Fixes for 26.04 12-factor extensions. /tmp and init templates.' and is already merged, indicating it is the rebased/superseded version of this PR (likely on the hotfix/1.21 branch requested in the unresolved review comment by @tigarmo).
Evaluated by: mr-cal-bot
Impact:
50
Quick Win:
16
Complexity:
20
Confidence:
85
Actionability:
40
Issue body
`paas-charm` stores its state under `/tmp/<framework>/state`. Bare rocks built with the Go and Express.js extensions don't contain a `/tmp`, so the charm unit fails on its first hook:
`PathError: mkdir /tmp.mkdir-new permission denied`
The Flask, Django and FastAPI extensions worked around this with a hand-rolled mkdir -m 777 ${CRAFT_PART_INSTALL}/tmp . Spring Boot staged the `base-files_tmp` chisel slice. Go and Express.js did neither.
Homogenize all frameworks using `bare` image to stage the `base-files_tmp` slice and remove the manual `mkdir`. `paas-charm` will use `/tmp` in all frameworks to use internal temporary information.
Also update and fix comments in 12-factor init templates.
Related to: https://github.com/canonical/paas-charm/pull/388
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
16
Complexity:
20
Confidence:
85
Actionability:
40
|
close superseded | Fixes /tmp staging for 12-factor extensions and updates init templates. Approved by 2 reviewers but has 1 unresolved comment requesting rebase onto hotfix/1.21. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Superseded By:
rockcraft#1399
(confidence 90%)
Identical title and merged status indicate #1399 supersedes #1387, likely after rebasing onto hotfix/1.21 as requested in review.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1399 chore: Fixes for 26.04 12-factor extensions. /tmp and init templates. | rockcraft | merged | Merged PR fixing 26.04 12-factor extensions by staging base-files_tmp slice for bare rocks, resolving paas-charm /tmp permission errors, and updating init templates. | |
| #924 chore(merge): hotfix/2.1 into main | craft-parts | closed | Merged hotfix/2.1 into main through PR #924, carrying 10 changed files (+50/-16). | |
| #2780 chore(hotfix): track 3.5 CI fixes | charmcraft | open | Draft tracking PR for hotfix/3.5 CI fixes: 13 files, +780/-426. Core unit/slow/lint CI green; 16 checks still pending, 3 unresolved review comments, no reviewers yet. | |
| #630 chore(merge): 'hotfix/1.5' into 'main' | rockcraft | merged | Merged hotfix/1.5 into main via PR #630 at commit 1a5740ad after two approvals; 4 files changed (+13/-12). | |
| #412 chore: merge origin/main | rockcraft | merged | Merged main into feature/12f, rebasing 12-factor work on recent refactorings and switching base notation to ubuntu@22.04 (128 files, +2406/-3031); approved by 3 reviewers. | |
| #832 chore(merge): 'hotfix/5.6' into 'main' | craft-application | merged | Merged hotfix/5.6 into main via #832 at commit 8c644216; two reviewers approved and all CI checks passed. | |
| #321 chore: merge 'hotfix/2.6' back into 'main' | craft-application | closed | Merged hotfix/2.6 back into main via PR #321 (commit 9ee94b68), with two approvals and no unresolved review comments. | |
| #536 chore(deps): update bugfixes | rockcraft | merged | Renovate bugfix PR merged as commit b33a48c9, bumping 11 dev/test dependencies (cachetools, coverage, cryptography, filelock, keyring, nh3, pyparsing, rich, tomlkit, virtualenv, wcmatch) across 3 files (+14/-14), with 2 approvals. | |
| #364 chore(deps): update dependencies | rockcraft | merged | Merged dependency updates in PR #364 via commit 1661d115, changing seven files (+152/-174) after approval by two reviewers. | |
| #353 chore: fix indentation in init template | imagecraft | merged | Merged PR #353 fixed indentation and minor formatting in the init template; committed as d13f4f1. Related documentation updates were made in merged PR #354. |