← Back to issue list

fix: add copybutton and simplify dependencies

View original Github issue

Metadata

Project
rockcraft
Number
#156
Type
pull request
State
closed
Author
cjdcordeiro
Labels
—
Created
Updated
Closed

Current evaluation

PR #156 (unmerged) fixed Read the Docs failures; the same changes landed via PR #158, merged as commit 716bc48f 'docs: add copybutton and simplify dependencies'. #156 was then closed as superseded.

Resolution: closed superseded

Reason: PR #156 was never merged (review status pending, 0 reviewers) and was replaced by rockcraft#158, merged as commit 716bc48f, which added the furo theme and sphinx-copybutton to the docs dependencies and relaxed version ranges. The current tree still carries both furo (pyproject.toml, uv.lock) and sphinx-copybutton (pyproject.toml line 57, registered in docs/conf.py line 224).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes documentation build. RTD are failing to build because the `furo` theme is not in the pip requirements. Added it, plus: - a new Sphinx `copybutton` module for code-blocks - improvement of the dependencies version ranges, to make it work with older OS releases - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #156 (unmerged) fixed Read the Docs failures; the same changes landed via PR #158, merged as commit 716bc48f 'docs: add copybutton and simplify dependencies'. #156 was then closed as superseded.
stealth/space-bunny-alpha — closed superseded Documentation fixes landed via #158 (commit 716bc48f), adding the furo theme, Sphinx copybutton, and relaxed dependency ranges for older OS releases. Closed PR #156 was superseded.
qwen/qwen3.6-35b-a3b — — Merged to resolve ReadTheDocs build failures by adding the furo theme, Sphinx copybutton module, and updating dependency version ranges for older OS compatibility.
qwen3.6-35b-a3b-mtp-q6 — — Merged to fix ReadTheDocs build failures. Added the furo theme and Sphinx copybutton extension, while updating dependency version ranges for older OS compatibility.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#158 (confidence 95%)

    Merged PR carrying the identical docs fix (furo + sphinx-copybutton + relaxed dependency ranges) under the title 'docs: add copybutton and simplify dependencies'.

  • Likely Fixed By: canonical/rockcraft#158 (confidence 95%)

    Commit 716bc48f is the merge commit for the superseding PR and the point at which the RTD docs build fix entered the tree.

  • Related To: canonical/rockcraft#63 (confidence 55%)

    Later dependabot bump of sphinx-copybutton to v0.5.2 (commit 8cc8d441), confirming the dependency introduced by this work is still in use.

Related issues

Issue Project State Summary Similarity
#158 docs: add copybutton and simplify dependencies rockcraft merged Merged as commit 716bc48f: added Furo and Sphinx Copybutton to documentation dependencies, fixing Read the Docs builds and relaxing dependency ranges for older OS releases.
82%
#6078 chore(deps): add dependency sphinx-copybutton snapcraft merged Merged PR #6078 as commit 603626051, adding sphinx-copybutton to restore copy buttons in documentation code blocks after the starter-pack update.
71%