Make mypy linter more strict
Metadata
Current evaluation
Request to enforce disallow-untyped-defs in mypy was closed without implementation or discussion. No pull requests were opened, indicating the change was abandoned or superseded by other linting updates.
Suggested action: —
No scores available.
Issue body
Looks like the default mypy configuration is too lenient because there are a bunch of un-annotated function parameters. I think we should at least add `disallow-untyped-defs` for the code in the `rockcraft` package.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Request to enforce disallow-untyped-defs in mypy was closed without implementation or discussion. No pull requests were opened, indicating the change was abandoned or superseded by other linting updates. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The suggestion to enable disallow-untyped-defs in mypy for rockcraft was abandoned, receiving no discussion or follow-up changes. | |
| qwen/qwen3.6-35b-a3b | — | — | Requesting stricter mypy configuration via disallow-untyped-defs for the rockcraft package was closed without discussion or implementation, indicating abandonment. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without implementation. The request to add disallow-untyped-defs to mypy for the rockcraft package was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Adding disallow-untyped-defs to mypy for the rockcraft package was closed without implementation. Linter configuration remains unchanged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1314 Type checking: enable stricter mypy rules | charmcraft | closed | Superseded by a switch to the ty type checker. The request to enable stricter mypy rules was closed without implementation. | |
| #1315 (WIP) style: enable stricter mypy rules | charmcraft | closed | Abandoned due to inactivity. The draft pull request enabling stricter mypy rules received no reviews, comments, or CI checks after over 1000 days and was closed without merging. Issue #1314 remains unresolved. | |
| #6132 Linting breaks mypy | snapcraft | closed | Running the lint command removes mypy, breaking type checking. The report was closed without a fix or merge. No code changes or follow-up actions are documented, indicating the bug was abandoned. |