oci: fix handling of symlink subdirs
Metadata
Current evaluation
Merged PR #211 in commit 1783fa2a, fixing OCI archive creation to include symlinked subdirectories and resolving #208.
Resolution: closed resolved
Reason: PR #211 was merged and added handling for symlink subdirectories when creating the OCI tar archive, resolving issue #208.
Evaluated by: mr-cal-bot
No scores available.
Issue body
When Rockcraft creates the tar archive from the priming area, subdirs symlinks are skipped from archive.
Solution is to add subdirs when they are symlinks.
Fix #208
- [] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #211 in commit 1783fa2a, fixing OCI archive creation to include symlinked subdirectories and resolving #208. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #211 in commit 1783fa2a, fixing OCI archive creation to include symlinked subdirectories and resolving #208. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix to correctly include symlinked subdirectories in Rockcraft OCI tar archives. Contributor implemented the change, reviewer added tests, and the pull request was approved and merged, resolving issue #208. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for Rockcraft skipping symlink subdirectories during tar archive creation from the priming area. The change adds logic to include these symlinks, resolving issue #208. Tests were added and the PR was approved. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/rockcraft#208
(confidence 100%)
The missing symlink behavior reported in #208 was fixed by merged PR #211.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #200 oci: fix handling of subdirs in usrmerge | rockcraft | merged | Merged in PR #200 as commit 3f43e30e, fixing OCI usrmerge so subdirectories beneath base-layer symlinks are written to the symlink target. | |
| #204 oci: handle duplicate directories because of usrmerge | rockcraft | merged | Merged #204 as c3382fc2, fixing OCI failures from usrmerge-aliased duplicate directories with matching attributes; mismatched attributes and file conflicts still error. | |
| #7 oci: pass filename to oci archive creation method (CRAFT-585) | rockcraft | merged | Merged PR #7 updated the OCI API so callers supply the archive filename; implementation 1350dcbd landed via merge commit 414d02b5. | |
| #208 Can't prime symlink in resulting oci | rockcraft | closed | Symlinked subdirs were dropped when building OCI layers because os.walk() does not follow symlinks. Fixed by merged PR #211 (commit 1783fa2a, "oci: fix handling of symlink subdirs") in rockcraft/layers.py. |