← Back to issue list

docs: include some docs from craft-parts

View original Github issue

Metadata

Project
rockcraft
Number
#247
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR pulling craft-parts docs into rockcraft was left unmerged and closed as redundant; the same docs refactor landed instead via rockcraft#515 (commit 5c2263f1, "refactor(docs): use more docs from craft-parts").

Resolution: closed superseded

Reason: Merged PR rockcraft#515 (commit 5c2263f1) completed the craft-parts documentation refactor, and lengau commented on 2023-09-19 that #247 could be closed because David (dboddie) had done the work in a separate PR.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Depends on craft-parts getting a release after https://github.com/canonical/craft-parts/pull/436 Sprint demo available at https://github.com/canonical/rockcraft/commit/73bb0f3fd2bccd1950b75eb1169909bd8305414b

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR pulling craft-parts docs into rockcraft was left unmerged and closed as redundant; the same docs refactor landed instead via rockcraft#515 (commit 5c2263f1, "refactor(docs): use more docs from craft-parts").
stealth/space-bunny-alpha — closed superseded Closed as redundant after rockcraft#515 merged the craft-parts documentation refactor in commit 5c2263f1.
qwen/qwen3.6-35b-a3b — — Superseded and closed. The documentation updates were completed and merged in a separate pull request by David, making this PR redundant.
qwen3.6-35b-a3b-mtp-q6 — — Superseded and closed without merging. The documentation updates were completed and merged in a separate pull request by David. Maintainer confirmed the original request was no longer needed.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#515 (confidence 97%)

    Merged refactor reusing craft-parts docs, matching #247's goal; maintainer confirmed closure due to it

  • Related To: canonical/craft-parts#436 (confidence 60%)

    Craft-parts PR #247 depended on a craft-parts release containing PR #436

Related issues

Issue Project State Summary Similarity
#515 refactor(docs): use more docs from craft-parts rockcraft merged Merged #515 refactored Rockcraft docs to reuse Craft Parts pages via direct TOC links or local includes (commit 5c2263f1).
88%
#314 docs: clean up references to Craft Parts rockcraft closed Craft Parts documentation cleanup was folded into canonical/rockcraft#308, merged as commit 13bf8368, and #314 was closed.
82%
#501 feat(docs): pull in content from craft-parts rockcraft merged Merged via commit 3f934304, importing Craft Parts content into 18 Rockcraft documentation files (+103/-17).
80%
#308 docs: imported the part properties reference from Craft Parts rockcraft merged Imported Craft Parts' part-properties reference into Rockcraft docs; PR #308 merged as 13bf8368 after upstream craft-parts#483 and #486 enabled and corrected the reusable documentation.
80%
#322 docs: enable inclusion of overlay document rockcraft merged Merged PR #322 in commit 181c9e1c, enabling inclusion of the Craft Parts overlay document in Rockcraft's documentation.
78%
#4679 refactor(docs): use more docs from craft-parts snapcraft merged Merged #4679 as b8c9a17dc, replacing duplicated Snapcraft docs with direct craft-parts TOC references or includes for shared content.
77%
#297 docs: rockcraft.yaml reference rockcraft closed Redirected to craft-parts documentation for `organize`; no Rockcraft PR or commit fixed the missing in-tree reference, and documentation integration was only planned.
76%
#419 docs: update / remove duplicate content rockcraft merged Merged #419, removing duplicate Rockcraft Parts and Chisel documentation and resolving #405; merge eb10855c, content commit bfce1f94.
74%
#300 docs: refactor documentation for sphinx-starter-pack rockcraft merged Merged PR #300 in commit 66911e8e, refactoring 28 documentation files to align Rockcraft with sphinx-starter-pack and ease future integration.
74%
#688 feat(docs)!: rework bundling of shared docs craft-parts merged Merged in 841244bd: reorganized reusable documentation under docs/common/craft-parts/ so Craft Parts and downstream applications can reference shared paths without conflicts.
74%