← Back to issue list

Discuss/investigate moving to tox + pyproject.toml

View original Github issue

Metadata

Project
rockcraft
Number
#285
Type
issue
State
open
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Maintainer task to consolidate rockcraft's build config (tox.ini, Makefile, setup.py, setup.cfg, pyproject.toml) toward starbase. Effectively done: setup.py/setup.cfg removed in #751, tox.ini removed, and the project fully migrated to starbase (uv + Makefile).

Suggested action: close stale

Reason: The issue's goal has been accomplished through the project's evolution: setup.py and setup.cfg were removed in 'chore: migrate setup.py to pyproject.toml (#751)', tox.ini was removed in 'chore: remove unused project files' (9e259450), and rockcraft has fully adopted starbase tooling (uv, common.mk, starflow CI) — exactly the 'closer to Starbase' aim. The issue has 0 comments and no activity for ~12.7 months, and its specific proposal (keep tox.ini) was superseded by the starbase migration, so it is no longer actionable.

Impact: 15 Quick Win: 9.0 Staleness: 75 Complexity: 40 Confidence: 80 Support Request: 5

Issue body

### What needs to get done The current code base has a mix of `tox.ini`, `Makefile`, `setup.py`, `setup.cfg` and `pyproject.toml`. We should look into keeping just tox.ini and pyproject.toml (plus the various `requirements*.txt` pins), to be closer to Starbase. ### Why it needs to get done Mostly for our own sanity, and to take advantage of the fact that we're still `edge`: I would prefer to have a "cleaner house" before we call it `stable`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 15
Quick Win: 9.0
Staleness: 75
Complexity: 40
Confidence: 80
Support Request: 5
close stale Maintainer task to consolidate rockcraft's build config (tox.ini, Makefile, setup.py, setup.cfg, pyproject.toml) toward starbase. Effectively done: setup.py/setup.cfg removed in #751, tox.ini removed, and the project fully migrated to starbase (uv + Makefile).
qwen/qwen3.6-35b-a3b
Staleness: 90
Complexity: 40
Confidence: 70
Support Request: 5
needs triage Proposal to consolidate build configuration to tox.ini and pyproject.toml. Unlabelled, zero maintainer comments, and inactive for over a year.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 30
Confidence: 80
Support Request: 5
close stale Maintenance task proposing to consolidate build configuration files into tox.ini and pyproject.toml. The issue has been open for over three years with no comments or maintainer engagement, indicating it is likely stale.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 40
Confidence: 75
Support Request: 5
needs triage Investigate consolidating build configuration to only tox.ini and pyproject.toml. Open with zero comments and inactive for over a year, awaiting discussion and assignment to streamline the codebase before stable release.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: rockcraft#751 (confidence 75%)

    PR 'chore: migrate setup.py to pyproject.toml' removed setup.py and setup.cfg, addressing the core consolidation goal of this issue.

  • Related To: starbase#53 (confidence 65%)

    Merged starbase PR moving tox deps into pyproject.toml — same build-config consolidation theme referenced by this issue.

Related issues

Issue Project State Summary Similarity
#11 tools: use the starbase tox config craft-grammar merged Merged to adopt the starbase tox configuration. The update adds tox.ini and modifies five configuration files, totaling 183 additions. Approved by one reviewer and integrated into the main branch.
70%