← Back to issue list

fix(ci): correct conditional for snap publication

View original Github issue

Metadata

Project
rockcraft
Number
#356
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged a fix correcting an invalid conditional in the GitHub Actions workflow for snap publication. The change resolved an unrecognized SNAPCRAFT_STORE_CREDENTIALS variable reference in snap.yaml. Approved by three reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

The workflow is not valid. .github/workflows/snap.yaml (Line: 41, Col: 13): Unrecognized named-value: 'SNAPCRAFT_STORE_CREDENTIALS'. Located at position 1 within expression: SNAPCRAFT_STORE_CREDENTIALS != '' - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix correcting an invalid conditional in the GitHub Actions workflow for snap publication. The change resolved an unrecognized SNAPCRAFT_STORE_CREDENTIALS variable reference in snap.yaml. Approved by three reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a fix correcting an invalid conditional check for the SNAPCRAFT_STORE_CREDENTIALS variable in the GitHub Actions snap workflow, resolving the pipeline validation error.
qwen3.6-35b-a3b-mtp-q6 Merged fix for GitHub Actions workflow error in snap.yaml. Corrected an invalid conditional expression referencing the unrecognized named-value SNAPCRAFT_STORE_CREDENTIALS, resolving the CI validation failure.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6098 fix: Tweak error message about SNAPCRAFT_STORE_CREDENTIALS snapcraft merged Merged to clarify the ambiguous SNAPCRAFT_STORE_CREDENTIALS error message. The update explicitly states login fails while the variable is set, resolving user confusion. Approved by four reviewers and passed CI checks prior to merge.
74%
#3388 ci: migrate snap publishing to github actions snapcraft merged Migrated snap publishing to GitHub Actions. Approved by one reviewer and merged into master, changing three files and increasing test coverage by 0.32%.
73%
#809 fix(ci): install correct dependencies in the release workflow craft-application merged Merged a fix for the CI release workflow that corrected dependency installation, resolving a broken GitHub Actions run. Approved by two reviewers with minimal code changes (+4/-2 lines).
72%
#1916 fix(ci): move actions from snapcore to canonical charmcraft merged Merged. CI actions migrated from snapcore to canonical after snapcore/action-publish lost tags. Approved by two reviewers and applied to a single file.
71%
#417 fix: allow using a snap from the snap store craft-application merged Merged a fix defaulting to the stable channel for snap store snaps, enabling channel overrides via the CRAFT_SNAP_CHANNEL environment variable. Approved by reviewers, passed CI, and modified two files.
71%
#307 ci: pack snap using craft-actions imagecraft merged Merged. Updated CI pipeline to replace action-build with the craft-actions snapcraft pack action. Approved by two reviewers and passed CI checks. The change updates a single workflow file.
71%
#97 fix: snap watch permissions and variable scope bugs in workflows starflow merged Merged fix for snap watch permission mismatches and variable scope bugs in GitHub Actions workflows. Corrected command substitution, added sudo to scan workflows, and fixed variable references. All CI checks passed.
71%