← Back to issue list

Move "build_for_variant" from the Project to the Image

View original Github issue

Metadata

Project
rockcraft
Number
#358
Type
issue
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

The Project-to-Image build_for_variant refactor was abandoned; #358 closed after prolonged inactivity with no linked implementation or closing comment.

Resolution: closed stale

Reason: Repository records show #358 was closed without a linked PR, comment, or documented implementation. Commit 340064d2 from #380 touched build_for_variant, but no evidence identifies it as the issue's resolution.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Drop the "build_for_variant" from the `Project`, and move the existing logic to the `Image` factory methods. ### Why it needs to get done The "build_for_variant" property of platforms is "hidden" in the sense that the user can't see or set it, and is only used when fetching the base image from the registry.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale The Project-to-Image build_for_variant refactor was abandoned; #358 closed after prolonged inactivity with no linked implementation or closing comment.
stealth/space-bunny-alpha — closed stale The build_for_variant relocation was abandoned: rockcraft#358 closed with no linked PR, comments, or documented resolution after prolonged inactivity.
qwen/qwen3.6-35b-a3b — — Moving build_for_variant from Project to Image was closed without implementation. No pull requests were linked or discussed, indicating the change was abandoned.
qwen/qwen3.6-35b-a3b — — Closed. The requested refactoring was implemented, moving build_for_variant logic from Project to Image factory methods. The property remains internal for base image registry lookups.
qwen/qwen3.6-35b-a3b — — Closed without implementation or linked pull request. The proposed refactor to relocate build_for_variant logic from Project to Image factory methods was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Moving build_for_variant from Project to Image was closed without comments or linked pull requests, indicating the change was abandoned without implementation.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#380 (confidence 65%)

    Commit 340064d2 changed code involving build_for_variant but was not recorded as resolving #358.

Related issues

No related issues found above the similarity threshold.