← Back to issue list

build: set version from git

View original Github issue

Metadata

Project
rockcraft
Number
#396
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #396 as commit 2ef84cb8, adding Git-derived versioning, snapcraft.yaml adopt-info, and relocating overlay initialization to the lifecycle service.

Resolution: closed resolved

Reason: PR #396 was approved and merged as commit 2ef84cb8. The merged change sets the package version dynamically from Git, configures snapcraft.yaml to adopt it, and enables overlay support in the lifecycle service.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This commit pulls in the "dynamic" version setting (from git) from Starbase, and updates snapcraft.yaml to use that version (via adopt-info). A consequence of this is that, in order to be able to run "python3 setup.py --version" without the dependencies installed, the enabling of the overlay feature is moved from ``rockcraft/__init__.py`` to the lifecycle service, which makes more sense any way as it's a feature specific to that service. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #396 as commit 2ef84cb8, adding Git-derived versioning, snapcraft.yaml adopt-info, and relocating overlay initialization to the lifecycle service.
stealth/space-bunny-alpha — closed resolved Rockcraft PR #396 merged as commit 2ef84cb8, switching builds to Git-derived versions and snapcraft.yaml adopt-info while moving overlay initialization into the lifecycle service.
qwen/qwen3.6-35b-a3b — — Merged PR that updates the build system to dynamically set the version from git via Starbase and snapcraft.yaml. Relocated overlay feature initialization to the lifecycle service. Approved by two reviewers, passed CI, and merged (+54/-8 lines, 7 files).
qwen3.6-35b-a3b-mtp-q6 — — Merged. Dynamically sets the version from git via Starbase and updates snapcraft.yaml to adopt it. Moves overlay feature initialization from the package init file to the lifecycle service for improved architecture.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1260 meta: version from git support. snapcraft merged Merged PR #1260 in commit 1a936f40c, adding version: git support so Snapcraft derives project versions from Git tags.
77%
#1789695 move to new version setting snapcraft (launchpad) closed Snapcraft migrated from "version: git" to custom set-version handling in merged PR #2230 (commit e1b59b75b), completing the planned version-setting change.
74%
#3779 meta: handle version git snapcraft merged Merged PR #3779 as cde2c51c5, adding support for version: git so snap versions come from git describe --dirty, with unit and spread coverage.
70%