← Back to issue list

refactor(project): drop ProjectValidationError

View original Github issue

Metadata

Project
rockcraft
Number
#440
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged #440 as 47b1576a, replacing ProjectValidationError with craft-application's CraftValidationError and removing duplicated error-formatting code.

Resolution: closed resolved

Reason: Pull request #440 was approved and merged into main as commit 47b1576a, completing the validation-error refactor.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Drop rockcraft's ProjectValidationError in favour of craft-application's CraftValidationError. This lets us remove a bunch of duplicated code related to formatting the errors and aligns us more closely with upstream.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #440 as 47b1576a, replacing ProjectValidationError with craft-application's CraftValidationError and removing duplicated error-formatting code.
stealth/space-bunny-alpha — closed resolved Merged PR #440 replaced Rockcraft's ProjectValidationError with craft-application's CraftValidationError, removing duplicated formatting code. The change landed as commit 47b1576a.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#440 (47b1576a), replacing ProjectValidationError with craft-application's CraftValidationError and removing duplicated error-formatting code.
stealth/space-bunny-alpha — closed resolved Merged PR #440 replaced Rockcraft's ProjectValidationError with craft-application's CraftValidationError, removing duplicated error-formatting code.
qwen/qwen3.6-35b-a3b — — Merged a refactor replacing ProjectValidationError with craft-application's CraftValidationError. This removes duplicated error formatting code, aligns with upstream, and reduces 116 lines across five files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactor replacing ProjectValidationError with craft-application's CraftValidationError. This removed duplicated error formatting logic and aligned the project with upstream dependencies.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#502 Refactor platform validation rockcraft open Refactor platform validation by consolidating it in Project and removing BuildPlanner. Resolved via migration to craft-application 5.
72%