fix(spread): tests must also use newer Chisel
Metadata
Current evaluation
Merged. Resolves failing spread tests by switching Chisel installation from a hardcoded commit to the snap store. Addressed review feedback and re-triggered CI after a timeout.
Suggested action: —
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
After https://github.com/canonical/chisel-releases/pull/78, the spread tests are now also failing because the building of the Chisel tool was still being done manually, from a hardcoded commit.
This PR changes the failing spread tasks such that Chisel is also installed from the snap store.
Fixes the tests for https://github.com/canonical/rockcraft/pull/455#issuecomment-1890672106.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Resolves failing spread tests by switching Chisel installation from a hardcoded commit to the snap store. Addressed review feedback and re-triggered CI after a timeout. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated spread test tasks to install Chisel from the snap store instead of building it from a hardcoded commit, resolving CI failures. The change passed tests after a transient timeout was re-triggered. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated spread tests to install Chisel from the snap store instead of a hardcoded commit, resolving test failures. The change was merged after a transient timeout was re-triggered and passed. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #469 fix(spread): tests must also use newer Chisel (#456) (#466) | rockcraft | closed | Merged via cherry-pick into main to prepare the 1.1.2 release. Updates spread tests to use the newer Chisel version. Passed CI checks and required no reviews. | |
| #466 fix(spread): tests must also use newer Chisel (#456) | rockcraft | merged | Merged a cherry-picked commit from main to align tests with the newer Chisel version, facilitating the 1.1.2 release. Approved by one reviewer. | |
| #467 fix(spread): tests must also use newer Chisel (#456) (#466) | rockcraft | closed | Merged and closed as a cherry-pick from main to update test dependencies to a newer Chisel version for the 1.1.2 release. | |
| #162 Use Chisel `main` branch for Spread tests | rockcraft | closed | Resolved by merging upstream Chisel PR #36. Repository configuration updated to clone the Chisel main branch for Spread tests, replacing the temporary development branch workaround. Issue closed as fixed. | |
| #155 spread: fix project with dotnet chisel slices | rockcraft | merged | Merged to remove an obsolete prime override and symlink in the spread configuration, as dotnet packages no longer create version-specific subdirectories. The change resolved CI failures blocking other pull requests. | |
| #13 test(spread): add more spread tests | snapcraft-rocks | merged | Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines). | |
| #1308 fix(test): mark chisel integration tests as flaky | craft-parts | merged | Merged changes marking chisel integration tests as flaky to accommodate intermittent network failures. Approved by two reviewers, passed CI checks, and resolves issue #1306. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #230 snap: update chisel to latest main | rockcraft | merged | Merged update to the chisel dependency, aligning the snap package with the latest main branch. Approved by two reviewers with zero comments and a single-line change. | |
| #5075 tests: fix validation sets spread test | snapcraft | merged | Merged fix for validation sets spread test switching to the hello-world snap and flipping the presence check instead of a specific revision. Approved by two reviewers with passing CI, resolving issue #5053. |