← Back to issue list

Issues/45/add base metadata

View original Github issue

Metadata

Project
rockcraft
Number
#46
Type
pull request
State
merged
Author
cjdcordeiro
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #46 (commit 24fb822f), adding base name and digest to ROCK metadata and recording the digest in labels/annotations; fixes #45.

Resolution: closed resolved

Reason: PR #46 was approved and merged as commit 24fb822f, resolving issue #45 by adding the missing base information to the .rock metadata.

Evaluated by: mr-cal-bot

No scores available.

Issue body

From the project base, takes the base name and digest, and adds: - the base name to the ROCK metadata file - the base digest to both the ROCK metadata file and labels&annotations **note:** for `bare` bases, the digest is being taken into consideration, even though in these cases, the base is created from nothing...should digest be `None` in these cases? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? fixes #45 -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #46 (commit 24fb822f), adding base name and digest to ROCK metadata and recording the digest in labels/annotations; fixes #45.
stealth/space-bunny-alpha — closed resolved Merged canonical/rockcraft#46, adding base name and digest to ROCK metadata and the digest to labels/annotations, fixing canonical/rockcraft#45.
qwen/qwen3.6-35b-a3b — — Merged to add base name and digest to ROCK metadata and labels, resolving issue #45. Code updated to handle skopeo digest preservation and bare base digest handling before final merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds base name and digest to ROCK metadata and labels/annotations, resolving issue #45. Commit updated for skopeo digest behavior, maintaining consistent handling for bare bases.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#45 (confidence 100%)

    Issue #45 requested the base metadata implemented by merged PR #46.

Related issues

Issue Project State Summary Similarity
#45 fix: missing base information in the .rock metadata file rockcraft closed Fixed in merged PR #46 (commit 24fb822f), adding base and base-digest fields and annotations to .rock metadata.
89%
#1131 fix: remove base.digest for bare-based rocks rockcraft merged Merged PR #1131 (commit b3d29d12) by external contributor zhijie-yang: project.py now only emits base-digest metadata and the OCI org.opencontainers.image.base.digest annotation when base != 'bare'. Shipped in rockcraft 1.17.2.
74%
#1401 fix: prefix base digest with sha256 in OCI annotation and rock metadata rockcraft open Prefixes base-image digests with sha256: in the OCI annotation and /.rock/metadata.yaml; tests are updated and the PR awaits maintainer review.
72%