Allow additionalProperties under "parts/plugin" in rockcraft schema
Metadata
Current evaluation
Merged PR #471 (commit 223431fd) to generate plugin-specific schema dynamically, allowing valid properties under parts.plugin while leaving final validation to Rockcraft.
Resolution: closed resolved
Reason: PR #471 was merged into main as commit 223431fd, resolving schema validation failures for valid plugin-specific properties under parts.plugin.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
## Description
Currently, Rockcraft schema doesn't allow additional fields under `plugin`, a field under `parts`. There are different values that can be used for `plugin`, and for each value, there is a different set of plugin properties that can be used under that plugin. The current schema generator, using pydantic's schema function, can't crawl the subclassed PluginProperties models in order to include their respective plugin properties and whitelist them.
With the current `additionalProperties` setting of the `plugin` field set to `false`, Rockcraft schema may consider a `rockcraft.yaml` invalid when its syntax is actually correct. In order to avoid that, we are going to whitelist all additional properties under `plugin`, even if it means whitelisting incorrect properties too, letting rockcraft be the final judge of them.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #471 (commit 223431fd) to generate plugin-specific schema dynamically, allowing valid properties under parts.plugin while leaving final validation to Rockcraft. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #471: Rockcraft’s schema now permits additional properties under parts.plugin, preventing false validation failures; plugin-specific validation remains with Rockcraft. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates the Rockcraft schema to allow additional properties under the plugin field, preventing false validation errors for valid configurations. Validation is deferred to Rockcraft. Approved by two reviewers and merged following schema regeneration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged schema update allowing additionalProperties under the plugin field. This prevents false validation errors for valid rockcraft.yaml files by whitelisting plugin properties and deferring final checks to the application. Rebased and regenerated schema before merge. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.