← Back to issue list

Update `flask-framework` extension

View original Github issue

Metadata

Project
rockcraft
Number
#499
Type
pull request
State
merged
Author
weiiwang01
Labels
—
Created
Updated
Closed

Current evaluation

Merged via #595 (commit 5eb5c512), updating the Flask extension with renamed parts, StatsD/CA certificate dependencies, custom-command WSGI handling, and improved part generation.

Resolution: closed resolved

Reason: The work from PR #499 landed in canonical/rockcraft#595 via commit 5eb5c512. Git history identifies the merged change as “feat: improve flask-framework.”

Evaluated by: mr-cal-bot

No scores available.

Issue body

Some refactoring was performed, and some improvements were made over the `flask-framework` extension. Changes include: * Update the extension part name prefix from `flask/` to `flask-framework/`. * Install `statsd-exporter` along with the Gunicorn server. * Install ca-certificates in the ROCK image by default. * Disable the WSGI path check when `services.flask.command` is overridden. * Improve the quality of generated parts. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged via #595 (commit 5eb5c512), updating the Flask extension with renamed parts, StatsD/CA certificate dependencies, custom-command WSGI handling, and improved part generation.
stealth/space-bunny-alpha — closed resolved Merged as canonical/rockcraft#595 (5eb5c512), updating flask-framework with renamed parts, Gunicorn/StatsD and CA-certificate dependencies, custom-command WSGI handling, and improved part generation.
stealth/space-bunny-alpha — closed resolved Merged canonical/rockcraft#499 (a6d85d06), updating flask-framework with new part prefixes, statsd-exporter and CA certificates, a conditional WSGI check, and better generated parts.
qwen/qwen3.6-35b-a3b — — Merged update to flask-framework extension with refactoring, added statsd-exporter and ca-certificates, and improved part generation. Linter errors from an external site outage were resolved. Changes merged after a related hotfix.
qwen3.6-35b-a3b-mtp-q6 — — Merged after a hotfix. Updates the flask-framework extension with refactoring, installs statsd-exporter and ca-certificates, disables WSGI path checks on command overrides, and improves part generation. Linter errors resolved.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/rockcraft#595 (confidence 99%)

    Follow-up PR #595 merged commit 5eb5c512 with the requested flask-framework improvements.

Related issues

Issue Project State Summary Similarity
#1257 Add the flask extension charmcraft merged Merged as an experimental Flask extension change; the completed flask-framework implementation landed in follow-up PR #1582 via commit c060832a.
70%