← Back to issue list

fix(spread): more robust check of non-pruned files

View original Github issue

Metadata

Project
rockcraft
Number
#520
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #520 improved the layer-pruning spread test to compare file contents when metadata matched, preventing false failures after a libuuid1 update.

Resolution: closed resolved

Reason: PR #520 was approved and merged as commit d0386b19. The test now checks contents as well as size, ownership, and permissions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The spread test for the "layer pruning" feature worked by comparing the stats of two files if they exist in both layers. These stats - filesize, ownership and permission bits - were enough up until now because the non-pruned files differed on at least the filesize. The recent release of libuuid1 broke this expectation: this new package has a ``libuuid.so.1.3.0`` with identical file size as the previous version, but different contents. So the pruning correctly kept the file, but the test failed. Update the test to _also_ check the files' contents if necessary. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #520 improved the layer-pruning spread test to compare file contents when metadata matched, preventing false failures after a libuuid1 update.
stealth/space-bunny-alpha — closed resolved Merged PR #520 fixed the layer-pruning spread test by checking file contents when metadata matched, resolving failures caused by libuuid1 updates.
qwen/qwen3.6-35b-a3b — — Merged a fix for a failing layer pruning spread test. The test relied on file stats, failing after libuuid1 updated with identical size but different contents. The update now verifies file contents alongside stats for robust non-pruned file checks. Approved and merged after passing CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to layer pruning spread test verifying file contents alongside stats. Resolves failures from libuuid1 updates changing contents without altering sizes, ensuring robust non-pruned file validation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1199 test: add a spread test for pebble pruning rockcraft merged Merged PR #1199 as commit 591fea81, adding a spread test for Pebble pruning and detection of mismatched file metadata.
71%