← Back to issue list

feat: JLink plugin

View original Github issue

Metadata

Project
rockcraft
Number
#688
Type
pull request
State
closed
Author
vpa1977
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; JLink support instead arrived through Craft Parts in 4a001f54 and received smoke-test coverage in merged PR #797.

Resolution: closed superseded

Reason: The author closed the standalone plugin after the design was redirected into the Java plugin. Rockcraft later enabled Craft Parts' JLink support in commit 4a001f54, documented it for 1.8, and merged validation in PR #797.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This PR adds jlink plugin that allows to generate Java runtime tailored for the Java application. When ran without supplying jar file property it will search the staging area for any jars and generate an image for them. If no jar files are found, then java.base image will be generated. This PR includes unit and integration tests. The plugin documentation is split into separate PR: https://github.com/canonical/rockcraft/pull/689 Sample ROCK using plugin: https://github.com/canonical/openjdk-rocks/tree/prototype/demos/java-runtime

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; JLink support instead arrived through Craft Parts in 4a001f54 and received smoke-test coverage in merged PR #797.
stealth/space-bunny-alpha — closed superseded Closed unmerged after the team chose to implement JLink as options in the base Java plugin; companion documentation PR #689 was also abandoned.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of JLink options in the base Java plugin; the author confirmed this replacement approach in the 2024-11-19 closing comment.
qwen/qwen3.6-35b-a3b — — Closed without merging. Maintainers decided to integrate JLink functionality as an option within the base Java plugin instead of maintaining a separate plugin. The standalone feature was abandoned in favor of this unified approach.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. Maintainers opted to implement jlink functionality as an option within the base Java plugin rather than adding a separate plugin. The contribution was abandoned to align with the revised architectural approach.

Update history

No update history recorded yet.

Related work

  • Related To: rockcraft#689 (confidence 99%)

    Companion documentation PR for the standalone JLink plugin was also closed unmerged as obsolete.

  • Superseded By: rockcraft#797 (confidence 90%)

    Merged smoke tests validated the eventual Craft Parts-based JLink plugin after this PR was abandoned.

Related issues

Issue Project State Summary Similarity
#951 feat: implement Jlink plugin craft-parts merged PR #951 merged as commit ba3891a0, adding the Jlink plugin with unit and integration tests, documentation, and support for building lean Java runtimes.
77%
#797 Validate jlink plugin rockcraft merged Merged PR #797 as commit 31428996, adding JLink plugin smoke-test coverage across 10 files after approval by two reviewers.
72%