← Back to issue list

update craft-cli to 1.2.0

View original Github issue

Metadata

Project
rockcraft
Number
#69
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #69 updated craft-cli to 1.2.0, adapted code to Emitter changes, enabled pylint, and kept autoformat from modifying virtualenv files (commit f20530d9).

Resolution: closed resolved

Reason: canonical/rockcraft#69 was merged as commit f20530d9. It completed the craft-cli 1.2.0 update and incorporated the associated Emitter and CI housekeeping changes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Some minor code updates to reflect the Emitter changes, following the steps taken in charmcraft's equivalent PR https://github.com/canonical/charmcraft/pull/801 Also did some minor housekeeping by enabling the 'pylint' linter in the linters CI job, and updating the 'autoformat' config to not _fix files in the virtualenv_ :scream:

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #69 updated craft-cli to 1.2.0, adapted code to Emitter changes, enabled pylint, and kept autoformat from modifying virtualenv files (commit f20530d9).
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#69 as f20530d9, updating craft-cli to 1.2.0 for Emitter changes, enabling pylint, and excluding virtualenv files from autoformat fixes.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#69 (f20530d9), updating craft-cli to 1.2.0 for Emitter changes, enabling pylint, and excluding virtualenv files from autoformat fixes.
qwen/qwen3.6-35b-a3b — — Merged update to craft-cli 1.2.0 to align with Emitter changes. Enabled pylint in CI and corrected autoformat config to exclude virtualenv. Approved and merged after passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer tigarmo. Updated craft-cli to 1.2.0 to align with upstream Emitter changes. Also enabled the pylint linter in CI and fixed the autoformat config to exclude the virtualenv directory.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#801 (confidence 98%)

    Referenced as the equivalent Emitter-update implementation that this PR followed.

Related issues

Issue Project State Summary Similarity
#116 Release 1.2 craft-cli merged craft-cli 1.2.0 was released by merged PR #116, bumping the package version from 1.1.0 to 1.2.0; adding a changelog file remained follow-up work.
74%
#107 Release 1.1.0 craft-cli merged Merged PR #107 released craft-cli 1.1.0 through a one-line version update; merge commit 720ddb9 includes release commit 899ca3d.
71%