← Back to issue list

feat: add Rockcraft-specific Poetry plugin

View original Github issue

Metadata

Project
rockcraft
Number
#717
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged the Rockcraft-specific Poetry plugin, resolving issue #701. Shared Python plugin logic was extracted into a python_common module. Approved by two reviewers, passed CI, and modified 19 files.

Suggested action:

No scores available.

Issue body

The plugin has the same behavior and restrictions as the Python plugin with regards to base-dependent behavior, symlink handling, sitecustomize, etc. Therefore, this common behavior is extracted into a new "python_common" module, used by both plugins. This approach is also taken for the reference docs - the requirement of staging a Python interpreter is the same for both plugins. Fixes #701 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the Rockcraft-specific Poetry plugin, resolving issue #701. Shared Python plugin logic was extracted into a python_common module. Approved by two reviewers, passed CI, and modified 19 files.
qwen3.6-35b-a3b-mtp-q6 Merged addition of a Rockcraft-specific Poetry plugin. Common Python plugin logic was extracted into a shared python_common module to eliminate duplication. Resolves issue #701.
qwen3.6-35b-a3b-mtp-q6 Merged a new Rockcraft-specific Poetry plugin that extracts shared Python plugin behavior into a python_common module. Resolves #701.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#222 plugins: add rockcraft specific python plugin rockcraft merged Merged a rockcraft-specific Python plugin supporting bare and ubuntu bases. Approved by two reviewers, the update modifies 26 files and closes issue #194.
81%
#1899 feat: add Python and Poetry plugins charmcraft merged Merged. Adds Charmcraft-specific Python and Poetry plugins for craft-parts, adjusting venv paths, using system pip, and auto-including src/lib dirs. Changes span 24 files with 841 additions and 44 deletions, approved by two reviewers.
77%
#792 feat: add uv plugin rockcraft merged Merged the addition of the uv plugin from craft-parts to Rockcraft. Approved by three reviewers, the change modifies 31 files. Minor CI test and OSV scanner warnings were deemed unrelated and did not block integration. Closes #789.
74%
#5090 feat: add Snapcraft-specific Poetry plugin snapcraft merged Merged a Snapcraft-specific Poetry plugin that extracts shared Python logic into a python_common module. Enabled for core22 and core24, resolves #5025, approved by two reviewers, and passed CI checks.
74%
#940 feat(plugins/poetry): add poetry and pip extra args craft-parts merged Merged feature adding extra arguments for poetry and pip commands to enable advanced user customization. Approved by three reviewers and passed CI checks.
71%
#1940 feat(docs): add python and poetry plugin docs charmcraft merged Merged documentation for Python and Poetry plugins. Builds on charmcraft PR #1939 and requires craft-parts PR #872 for full rendering. Approved by two reviewers, adding 144 lines across six files.
71%
#830 feat(docs): add poetry plugin reference craft-parts merged Merged after approval by two reviewers. The change adds documentation for a poetry plugin reference, introducing 107 lines across three files. The update was integrated into the main branch without further discussion.
71%
#634 feat: use versioned form of doc urls rockcraft merged Merged. Updates documentation URLs in error messages and rockcraft init templates to use versioned paths. Approved by two reviewers, passed CI, and modified eight files.
70%
#951 feat: implement Jlink plugin craft-parts merged Merged after implementing the Jlink plugin with unit and integration tests, documentation, and resolving issue #891. Approved by three reviewers with passing CI. A follow-up PR was created for rockcraft integration.
70%
#820 feat(plugin): add poetry plugin craft-parts merged Merged to add a Poetry plugin, resolving issue #707. Approved by two reviewers, the implementation adds 711 lines across 12 files to integrate Poetry support.
70%