feat: do not create /bin/java symlink
Metadata
Current evaluation
Merged PR overrides maven and ant plugins to prevent creating a /bin/java symlink, resolving craft-parts issue #813 and enabling rock builds. Approved by two reviewers. Follow-up PR #916 handles documentation overrides.
Suggested action: —
No scores available.
Issue body
This PR overrides maven and ant plugin to avoid creating /bin/java symlink : https://github.com/canonical/craft-parts/issues/813
This allows to use those plugins to build rocks.
The plugins still need to set JAVA_HOME manually which is addressed by https://github.com/canonical/craft-parts/pull/895
Raised https://github.com/canonical/rockcraft/pull/754 to address the linter error.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged PR overrides maven and ant plugins to prevent creating a /bin/java symlink, resolving craft-parts issue #813 and enabling rock builds. Approved by two reviewers. Follow-up PR #916 handles documentation overrides. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Overrides Maven and Ant plugins to prevent creating a /bin/java symlink, enabling rock builds. Follow-up PRs handle JAVA_HOME configuration and documentation updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to override maven and ant plugins, preventing /bin/java symlink creation and enabling rock builds. Follow-up PRs address JAVA_HOME configuration and documentation overrides. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #728 feat: maven rockcraft plugin | rockcraft | closed | Closed without merging. Proposed Maven plugin hardlink adjustments were moved to draft pending a craft-parts JAVA_HOME dependency. Reviewers requested dependency updates, but the contribution was abandoned without resolution. | |
| #813 java plugin should not link java under /bin | craft-parts | open | Java plugin hardcodes a /bin/java symlink, causing stage collisions in rockcraft builds. Maintainer acknowledged (Aug 2024) that an override option is needed but details are unresolved; no fix implemented, issue still open. | |
| #837 chore: split _get_java_post_build_commands | craft-parts | merged | Merged after approval and passing CI. Fixed a broken /bin/java link for rockcraft projects by splitting the Java link command function, enabling plugin overrides. Resolves issue #813. |