feat: do not create /bin/java symlink
Metadata
Current evaluation
Merged in canonical/rockcraft#752 as b7ea7434, preventing Maven and Ant plugins from creating /bin/java symlinks so those plugins can build rocks.
Resolution: closed resolved
Reason: PR #752 was approved and merged as commit b7ea7434. Its plugin overrides avoid the unwanted symlink, with canonical/rockcraft#754 addressing a related linter error.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR overrides maven and ant plugin to avoid creating /bin/java symlink : https://github.com/canonical/craft-parts/issues/813
This allows to use those plugins to build rocks.
The plugins still need to set JAVA_HOME manually which is addressed by https://github.com/canonical/craft-parts/pull/895
Raised https://github.com/canonical/rockcraft/pull/754 to address the linter error.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#752 as b7ea7434, preventing Maven and Ant plugins from creating /bin/java symlinks so those plugins can build rocks. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/rockcraft#752 prevents Maven and Ant from creating /bin/java symlinks, enabling rock builds; JAVA_HOME setup is covered separately by canonical/craft-parts#895. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/rockcraft#752 (commit b7ea7434) adds Maven/Ant overrides to prevent /bin/java symlinks, avoiding staging conflicts and enabling rock builds. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR overrides maven and ant plugins to prevent creating a /bin/java symlink, resolving craft-parts issue #813 and enabling rock builds. Approved by two reviewers. Follow-up PR #916 handles documentation overrides. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Overrides Maven and Ant plugins to prevent creating a /bin/java symlink, enabling rock builds. Follow-up PRs handle JAVA_HOME configuration and documentation updates. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/rockcraft#754
(confidence 100%)
Follow-up PR raised to resolve the linter error encountered by #752.
-
Likely Fixed By:
canonical/craft-parts#813
(confidence 98%)
The upstream craft-parts issue describes the plugin symlink problem addressed by this merged change.
-
Related To:
canonical/craft-parts#895
(confidence 95%)
Separate upstream work for setting JAVA_HOME when using Maven and Ant plugins.
-
Related To:
canonical/craft-parts#916
(confidence 90%)
Upstream change cited by the author to improve plugin documentation overrides.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #728 feat: maven rockcraft plugin | rockcraft | closed | Closed unmerged and superseded by #752 (commit b7ea7434), which added Maven/Ant overrides avoiding conflicting /bin/java symlinks. | |
| #1388 maven/ant plugins: `create_usr_bin_java` creates a stray `./java` link; second `rockcraft pack` fails | rockcraft | open | Maven/Ant plugins fail on re-builds because create_usr_bin_java uses test -f instead of test -e to check for existing java symlink |