tests: test lifecycle.py::_run_in_provider
Metadata
Current evaluation
Merged in commit 2f5b9c48, adding unit coverage for lifecycle.py::_run_in_provider() and raising lifecycle.py coverage from 16% to 36%.
Resolution: closed resolved
Reason: PR #83 was merged as commit 2f5b9c48. Its tests exercise _run_in_provider(), with reported lifecycle.py coverage increasing from 16% to 36%.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
New unit tests for `lifecycle.py::_run_in_provider()`. I referenced `charmcraft`'s unit testing, but it was still quite challenging to mock.
Before:
```
Name Stmts Miss Cover
--------------------------------------------
rockcraft/lifecycle.py 90 76 16%
```
After:
```
Name Stmts Miss Cover
--------------------------------------------
rockcraft/lifecycle.py 90 58 36%
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 2f5b9c48, adding unit coverage for lifecycle.py::_run_in_provider() and raising lifecycle.py coverage from 16% to 36%. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #83 by mr-cal merged into main (commit 2f5b9c48), adding unit tests for lifecycle.py::_run_in_provider and lifting lifecycle.py coverage from 16% to 36%. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#83 (commit 2f5b9c48), adding unit tests for lifecycle.py::_run_in_provider with mocked providers; lifecycle.py coverage rose from 16% to 36%. Approved by one reviewer. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 2f5b9c48: added unit tests for lifecycle.py::_run_in_provider, lifting rockcraft/lifecycle.py coverage from 16% to 36%; reviewer approved. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#83 (commit 2f5b9c48), adding tests for lifecycle.py::_run_in_provider and raising its coverage from 16% to 36%. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged unit tests for lifecycle.py::_run_in_provider(), increasing coverage from 16% to 36%. Approved by one reviewer, passed CI, and added 144 lines across three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged unit tests for lifecycle.py::_run_in_provider() by mr-cal. The commit improved rockcraft/lifecycle.py coverage from 16% to 36% by implementing mocks for provider execution. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #50 add unit tests for lifecycle.py | rockcraft | closed | Added tests/unit/test_lifecycle.py covering lifecycle.py's pack paths (mainly _run_in_provider) in PR #83, commit 2f5b9c48; maintainer closed the issue pointing to that commit. | |
| #3928 tests: mock and test provider calls from lifecycle.py | snapcraft | merged | Merged #3928 in commit f0173bef1, adding mocked craft-providers lifecycle tests, aligning verbosity handling with Charmcraft and Rockcraft, and increasing coverage by 0.10%. |