spread: add 'global' clean-up calls
Metadata
Current evaluation
Merged. Introduces global cleanup calls in spread tests to automatically remove Docker and LXC resources after each task. Approved by one reviewer and passed CI. A separate craft-providers configuration failure noted in comments did not block the merge.
Suggested action: —
No scores available.
Issue body
The commands in `restore-each` are run after each task, which lets us cleanup docker images/lxc containers/etc without having to "remember" to do it per-task.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Introduces global cleanup calls in spread tests to automatically remove Docker and LXC resources after each task. Approved by one reviewer and passed CI. A separate craft-providers configuration failure noted in comments did not block the merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added global cleanup calls to spread tests to automatically remove Docker images and LXC containers after each task. A CI failure regarding craft-providers instance config was noted but did not block the merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Introduces global cleanup calls in spread tests via restore-each to automatically remove Docker images and LXC containers after each task. A review comment noted a test failure, but the change was accepted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127. | |
| #1088 spread: only install docker for store tests | charmcraft | merged | Merged. Restricts Docker installation to store tests only via a +9/-5 line diff in the spread configuration. Approved by one reviewer with no comments. | |
| #62 spread: add a "big" spread test | rockcraft | merged | Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks. | |
| #282 spread: retry grepping docker logs | rockcraft | merged | Merged a change adding a retry helper for grepping Docker logs in spread tests. Resolves test flakiness from container startup delays. Approved by two reviewers, passed CI, and modified three files. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #2983 tests: add LXD spread test | snapcraft | merged | Merged after reviewer approval and passing CI checks. Added LXD spread test to verify LXD builds and installs. Modified two files with 29 added lines. | |
| #2631 spread tests: enable LXD build provider tests | snapcraft | merged | Merged into master. Enabled LXD build provider tests by relocating setup to the early prepare phase to reduce overhead and consolidating declarations from task.yaml to spread.yaml. Approved, passed CI, and increased coverage by 0.01%. | |
| #2118 fix: remove experimental spread init templates | charmcraft | merged | Merged removal of experimental spread init templates from the init command. Replaced by proper testing support in craft-application. Existing files remain unaffected. Approved by three reviewers and passed CI. | |
| #3540 spread tests: remove 16.04 and core (CRAFT-210) | snapcraft | merged | Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations. | |
| #2126 ci(docs): spread test documentation | charmcraft | merged | Merged changes adding a CI workflow for spread testing documentation and adjusting tasks for Google runners. Approved by two reviewers, the update modifies five files (+100/-22 lines) and resolves CRAFT-3798. |