← Back to issue list

fix(renovate): don't update dependencies in docs spread tests

View original Github issue

Metadata

Project
rockcraft
Number
#949
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #949 (lengau) proposed a 3-line .github/renovate.json5 change to exclude docs spread-test deps from Renovate, requested in #935. Closed unmerged; source-spread-tests failed and medubelko asked to reconsider.

Resolution: closed stale

Reason: The PR was closed without merging despite three approving reviews; medubelko's final comment argued the original request predated Erinecon becoming codeowner and that they now want Renovate flagging tutorial vulnerabilities for her to review. The current .github/renovate.json5 still only ignores docs/requirements.txt, confirming no change landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Requested here: https://github.com/canonical/rockcraft/pull/935#issuecomment-3220985303 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #949 (lengau) proposed a 3-line .github/renovate.json5 change to exclude docs spread-test deps from Renovate, requested in #935. Closed unmerged; source-spread-tests failed and medubelko asked to reconsider.
stealth/space-bunny-alpha — closed stale Closed unmerged after maintainers reconsidered excluding docs spread-test dependencies from Renovate. The source-spread-tests check failed, and no code change landed.
qwen/qwen3.6-35b-a3b — — Closed without merging. Despite approval, a failing CI check and a recent comment suggested reconsidering the change due to new discussions about using Renovate for vulnerability tracking in tutorials. The PR was abandoned.
qwen3.6-35b-a3b-mtp-q6
Staleness: 70
Complexity: 10
Confidence: 85
close stale Configures Renovate to skip dependency updates in docs spread tests. Open for ~10 months; recently questioned by a maintainer who suggests reconsidering due to new codeowner access and security scanning needs.
qwen3.6-35b-a3b-mtp-q6
Staleness: 20
Complexity: 10
Confidence: 85
close not mergeable Disables Renovate dependency updates for docs spread tests. A maintainer recently commented to reconsider the change, noting a shift in policy to allow Renovate to flag vulnerabilities in tutorials.

Update history

Date Change
closed

Related work

  • Caused By: canonical/rockcraft#935 (confidence 90%)

    Original Renovate dependency bump PR whose comment (issuecomment-3220985303) spawned the request; #935 itself closed unmerged.

Related issues

Issue Project State Summary Similarity
#111 feat(renovate): don't check docs directory starflow merged Renovate now ignores docs/requirements.txt, preventing unwanted starter-pack dependency update PRs; PR #111 was merged in commit db2a855.
74%
#2778 ci: configure Renovate to ignore docs updates charmcraft merged Merged PR canonical/charmcraft#2778 (approved by 2 reviewers) adds a Renovate ignorePaths entry for docs/**, so Renovate stops opening dependency update PRs that only touch documentation. One-line change to Renovate config.
74%
#115 feat: ignore test directories with renovate starflow merged Merged PR #115 as commit a5b244d, excluding test directories from Renovate scans so intentionally outdated test dependencies remain unchanged.
72%
#191 feat(renovate): configure PR automerge without ignoring tests starflow merged Configured Renovate to automatically squash-merge patch updates, dev dependencies, and internal releases once checks pass. Merged in PR #191.
72%
#450 ci(deps): prevent renovate from updating certain packages rockcraft merged Merged PR #450 as commit 34926914, adding Renovate exclusions to keep selected packages pinned in .github/renovate.json5.
71%
#2823 chore: configure renovate to ignore requirements files under tests/ charmcraft merged PR #2823 merged, adding `tests/**` to ignorePaths in .github/renovate.json5 so Renovate stops raising updates for test-fixture requirements files.
70%
#152 feat(renovate): don't scan against sphinx-stack deps starflow merged PR #152 merged as commit b5961a0, adding a renovate.json5 rule with matchJsonata "managerData.depGroup = 'docs-sphinx-stack'" and enabled:false so Renovate no longer opens PRs for the docs-sphinx-stack dependency group.
70%