Rocks 2419/allow single char names
Metadata
Current evaluation
Merged in canonical/rockcraft#2419 via commit 5a7a9789, allowing one- and two-character rock names and prefixing short Pebble layer names with -rockcraft-.
Resolution: closed resolved
Reason: PR #957 was merged. Repository metadata identifies canonical/rockcraft#2419 and commit 5a7a9789 as the landing point for the short-name support.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
This PR allows rockcraft to produce Rocks with less than three characters in the name by removing such restriction in `rockcraft` and using the one from parent class in `craft-application`. To prevent the resulting pebble layer to fail the validation, a `-rockcraft-` prefix is automatically added to the layer name.
### Related PR
https://github.com/canonical/craft-application/pull/894
Context: Although rockcraft itself will allow names with a single character, it will fail the validation for `title`. This is because when `title` is not set, Rockcraft will set the `title` value to be equal to the `name`. However, `title` has a `min_length` of `2` while `name` has a min length of `1`. The PR above aims to fix this situation.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#2419 via commit 5a7a9789, allowing one- and two-character rock names and prefixing short Pebble layer names with -rockcraft-. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 5a7a9789, enabling one- and two-character rock names and adding a -rockcraft- prefix to short Pebble layer names. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#2419 via commit 5a7a9789, allowing one- and two-character project names and prefixing short Pebble layer names with -rockcraft-. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged support for one-character rock names, delegating validation to craft-application and adding a -rockcraft- prefix to resulting Pebble layer names. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to allow Rockcraft to generate Rocks with single-character names by removing the prior length restriction. A -rockcraft- prefix is added to pebble layer names to pass validation. The change depends on a related craft-application PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged squash PR allowing rockcraft to generate rocks with single-character names by removing local restrictions. A -rockcraft- prefix is added to pebble layer names to prevent validation failures. Resolves ROCKS-2419. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#894
(confidence 98%)
Companion change addresses title validation when a one-character name is used.
-
Likely Fixed By:
rockcraft#2419
(confidence 90%)
Repository metadata identifies this PR and commit 5a7a9789 as the merge resolution.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #244 project: constrain ROCK name to pebble's rules | rockcraft | merged | Merged PR #244 in commit 1b7e1a02, restricting ROCK names to Pebble’s lowercase alphanumeric and hyphen format. | |
| #943 "name" validation is broken for names with 2 characters | rockcraft | closed | Fixed by merged PR canonical/rockcraft#957 in commit 5a7a9789, allowing valid one- and two-character rock names. |