← Back to issue list

Rocks 2419/allow single char names

View original Github issue

Metadata

Project
rockcraft
Number
#957
Type
pull request
State
merged
Author
alesancor1
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Merged to allow Rockcraft to generate Rocks with single-character names by removing the prior length restriction. A -rockcraft- prefix is added to pebble layer names to pass validation. The change depends on a related craft-application PR.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- This PR allows rockcraft to produce Rocks with less than three characters in the name by removing such restriction in `rockcraft` and using the one from parent class in `craft-application`. To prevent the resulting pebble layer to fail the validation, a `-rockcraft-` prefix is automatically added to the layer name. ### Related PR https://github.com/canonical/craft-application/pull/894 Context: Although rockcraft itself will allow names with a single character, it will fail the validation for `title`. This is because when `title` is not set, Rockcraft will set the `title` value to be equal to the `name`. However, `title` has a `min_length` of `2` while `name` has a min length of `1`. The PR above aims to fix this situation.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to allow Rockcraft to generate Rocks with single-character names by removing the prior length restriction. A -rockcraft- prefix is added to pebble layer names to pass validation. The change depends on a related craft-application PR.
qwen3.6-35b-a3b-mtp-q6 Merged squash PR allowing rockcraft to generate rocks with single-character names by removing local restrictions. A -rockcraft- prefix is added to pebble layer names to prevent validation failures. Resolves ROCKS-2419.
qwen3.6-35b-a3b-mtp-q6 Merged. Removes the three-character minimum for rock names, enabling single-character names. Automatically prefixes pebble layer names with -rockcraft- to pass validation. Resolves title length conflicts alongside craft-application PR #894.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#244 project: constrain ROCK name to pebble's rules rockcraft merged Merged changes constraining ROCK names to Pebble's rules: lowercase letters, numbers, and hyphens only. Approved by two reviewers, the update modifies five files to enforce consistent naming across layer files.
74%