← Back to issue list

refactor: consolidate base-specific knowledge

View original Github issue

Metadata

Project
rockcraft
Number
#974
Type
pull request
State
open
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Refactors Rockcraft to consolidate base-specific knowledge (support, pebble, plugins) into a single 'bases' module. Open 346 days with no activity, 2 unresolved review comments, no assigned reviewer, and a failing lint check.

Suggested action: needs review

Reason: The PR carries 2 unresolved review comments and has no assigned reviewer after 346 days of inactivity. The underlying goal remains valid—base-specific knowledge is still scattered across project.py (BaseT literals), architectures.py, and pebble logic—but the codebase has evolved significantly (new bases ubuntu@26.04/26.10, stonking) and the failing lint/files check indicates the diff needs updating before a meaningful review can occur.

Impact: 35 Quick Win: 19.25 Staleness: 80 Complexity: 45 Confidence: 65

Issue body

Instead of having the information about which base behaves which way with regards to support, pebble, plugins, etc, have a single "bases" module that serves as an authoritative source for all base-related knowledge. The idea is that someone can look at this single module and have a full view of how Rockcraft's behavior changes depending on the project's base. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 35
Quick Win: 19.25
Staleness: 80
Complexity: 45
Confidence: 65
needs review Refactors Rockcraft to consolidate base-specific knowledge (support, pebble, plugins) into a single 'bases' module. Open 346 days with no activity, 2 unresolved review comments, no assigned reviewer, and a failing lint check.
qwen/qwen3.6-35b-a3b
Staleness: 90
Complexity: 25
Confidence: 85
close stale Consolidates base-specific configuration and behavior into a single authoritative module. Currently inactive for over 10 months with no reviewer engagement or updates.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 55
Confidence: 65
close stale Refactors base-specific configuration into a centralized module to unify behavior across different bases. Currently inactive for nearly a year with an incomplete checklist and no maintainer feedback.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 40
Confidence: 80
close stale Refactors code to consolidate base-specific configuration into a single authoritative module. Currently inactive for 288 days with no comments, CI results, or maintainer feedback.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 45
Confidence: 70
needs review Consolidates base-specific behavior into a single authoritative bases module. Open for 269 days with no comments or reviews. Contribution checklist remains incomplete.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#715 refactor: use craft-platform for the build plans rockcraft merged Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files.
74%
#73 refactor: make rockcraft-pack follow new call conventions craft-actions merged Merged after approvals and CI. Refactored rockcraft-pack to adopt new conventions: actions in dedicated directories, tests co-located, shared logic in common/. Updated 17 files.
70%