← Back to issue list

make plugin assumes DESTDIR is supported by Makefile

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1609116
Type
issue
State
closed
Author
~nacc
Labels
Created
Updated
Closed

Current evaluation

Closed without resolution. The make plugin's hardcoded DESTDIR assumption for older Makefiles was not addressed, and no configuration option or internal variable exposure was added. The request remains effectively abandoned.

Suggested action:

No scores available.

Issue body

Older Makefiles (prior to DESTDIR's introduction, e.g.) may not use DESTDIR to specify the installation target. For example, redis uses PREFIX instead (https://github.com/antirez/redis/blob/unstable/src/Makefile). This leads to very simple wrappers for this kind of support (e.g., https://github.com/kyrofa/nextcloud-snap/blob/master/parts/plugins/x-redis.py) when it seems like something that should be specifiable in the yaml. Technically, PREFIX could be specified as a make-parameter, but the value needs to be settable to "self.installdir" as defined in the make plugin itself; but this value is not exposed in any way that I've found. So there are two solutions (both of which might be worth implementing): 1) Allow the specific Makefile environment variable for installation target to be specifiable (default would be DESTDIR?) 2) Expose the make plugin's internal variables (e.g., self.installdir) as YAML variables. This will need some consideration so it's clear to end users these are snap-specific variables.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without resolution. The make plugin's hardcoded DESTDIR assumption for older Makefiles was not addressed, and no configuration option or internal variable exposure was added. The request remains effectively abandoned.
qwen/qwen3.6-35b-a3b Closed without resolution. The make plugin request to allow configurable installation targets or expose internal variables was abandoned due to zero comments and no maintainer action.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1889268 `make` plugin interprets relative source paths incorrectly snapcraft (launchpad) closed Closed without comments or resolution. The make plugin incorrectly resolved relative source paths, triggering permission errors, but received no follow-up or fix.
70%