nodejs plugin does not download dependencies from package.json to the correct location
Metadata
Current evaluation
The nodejs plugin failed to download dependencies to the correct location due to a missing cwd argument. The author submitted a pull request to fix the oversight. The issue is closed, indicating the fix was merged and the bug resolved.
Suggested action: —
No scores available.
Issue body
hi,
as can be seen, the cwd argument has been omitted in this particular call:
https://github.com/snapcore/snapcraft/blob/2f0be35542620a251ba1b29a31d2b924029e2a2c/snapcraft/plugins/nodejs.py#L138
i'll submit a PR shortly.
jonathon
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | The nodejs plugin failed to download dependencies to the correct location due to a missing cwd argument. The author submitted a pull request to fix the oversight. The issue is closed, indicating the fix was merged and the bug resolved. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed via a pull request that added the missing cwd argument to the nodejs plugin, correcting package.json dependency download paths. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed after a pull request was merged to add the missing cwd argument to the nodejs plugin, fixing the dependency download location. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned. The missing cwd argument in the Node.js plugin causing incorrect dependency installation was never addressed via a pull request. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1623509 nodejs plugin does not download dependencies from package.json | snapcraft (launchpad) | closed | Abandoned. Closed without resolution. The nodejs plugin remains unpatched, continuing to skip devDependencies installation during build and breaking prepublish scripts. | |
| #1633298 nodejs plugin never runs install during pull | snapcraft (launchpad) | closed | Fixed the nodejs plugin to run npm install during the pull phase by correcting the builddir path check, resolving downstream build failures. |