← Back to issue list

Store review error itself errors out

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1676100
Type
issue
State
open
Author
~niemeyer
Labels
Created
Updated
Closed

Current evaluation

snapcraft crashed with IndexError when logging a StoreReviewError during snap push; the old storeapi error path was replaced by craft-store error handling, so the bug is no longer reproducible in current code.

Suggested action: close stale

Reason: The issue is 3446 days old with zero comments or maintainer interaction. The traceback references snapcraft/storeapi/__init__.py and snapcraft/_store.py, which no longer exist in the current codebase (grep for StoreReviewError, _push_snap, and raise_for_code returns no matches). Current store error handling in snapcraft/cli.py catches craft_store.errors.CraftStoreError and formats it via CraftError, so the original IndexError in the old errors.py __str__ path is no longer applicable.

Impact: 25 Quick Win: 17.5 Staleness: 95 Complexity: 30 Confidence: 80 Support Request: 5

Issue body

Uploading foo.snap [==========================================================] 100% Error while processing...| Traceback (most recent call last): File "/usr/lib/python3/dist-packages/snapcraft/main.py", line 244, in main return run(args, project_options) File "/usr/lib/python3/dist-packages/snapcraft/main.py", line 288, in run _run_store_command(args) File "/usr/lib/python3/dist-packages/snapcraft/main.py", line 349, in _run_store_command snapcraft.push(args['<snap-file>'], release_channels) File "/usr/lib/python3/dist-packages/snapcraft/_store.py", line 457, in push result = _push_snap(snap_name, snap_filename) File "/usr/lib/python3/dist-packages/snapcraft/_store.py", line 480, in _push_snap tracker.raise_for_code() File "/usr/lib/python3/dist-packages/snapcraft/storeapi/__init__.py", line 754, in raise_for_code raise errors.StoreReviewError(self.__content) snapcraft.storeapi.errors.StoreReviewError: <exception str() failed> During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/bin/snapcraft", line 31, in <module> snapcraft.main.main() File "/usr/lib/python3/dist-packages/snapcraft/main.py", line 249, in main logger.error(str(e)) File "/usr/lib/python3/dist-packages/snapcraft/internal/errors.py", line 42, in __str__ return self.fmt.format([], **self.__dict__) IndexError: tuple index out of range

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 25
Quick Win: 17.5
Staleness: 95
Complexity: 30
Confidence: 80
Support Request: 5
close stale snapcraft crashed with IndexError when logging a StoreReviewError during snap push; the old storeapi error path was replaced by craft-store error handling, so the bug is no longer reproducible in current code.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 20
Confidence: 90
Support Request: 5
close stale Error handling in snapcraft crashes when formatting a StoreReviewError, causing an IndexError during logging. Issue is over 9 years old with no maintainer interaction.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 15
Confidence: 95
Support Request: 0
close stale Error handling bug in snapcraft where StoreReviewError formatting fails, causing an IndexError during traceback. Issue is over 9 years old with no activity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 99
Complexity: 10
Confidence: 85
Support Request: 0
close stale Error message formatting bug causes crash when displaying a StoreReviewError. Issue is over 9 years old with no activity or maintainer engagement.
qwen3.6-35b-a3b-mtp-q6
Staleness: 98
Complexity: 15
Confidence: 90
Support Request: 0
close stale Snapcraft crashes when formatting a StoreReviewError

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6310 fix(store): raise error when upload processing status is 'error' snapcraft open Fixes snapcraft upload --release silently reporting success when store review fails by checking status code 'error' in notify_upload. Waiting for maintainer review for 72 days.
70%