godeps using seemingly invalid commit hash
Metadata
Current evaluation
Closed without resolution. The hardcoded commit hash in the godeps plugin causing checkout failures was not addressed, likely abandoned or superseded by newer plugin versions.
Suggested action: —
No scores available.
Issue body
My CI has been failing for a while with a confusing error when building a godeps part:
Pulling mdns-publisher
+ snapcraftctl pull
Cloning into '/home/circleci/nextcloud-snap/parts/mdns-publisher/src'...
remote: Enumerating objects: 163, done.
remote: Total 163 (delta 0), reused 0 (delta 0), pack-reused 163
Receiving objects: 100% (163/163), 44.12 KiB | 2.10 MiB/s, done.
Resolving deltas: 100% (82/82), done.
Fetching godeps...
go get -d github.com/rogpeppe/godeps
go: downloading github.com/rogpeppe/godeps v0.0.0-20180524172459-404a7e748cd3
go: downloading github.com/kisielk/gotool v1.0.0
go: downloading github.com/pelletier/go-toml v1.8.1
go: downloading golang.org/x/tools v0.1.0
go: downloading golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4
git checkout 4e9e0ee19b60b13eb79915933f44d8ed5f268bdd
fatal: reference is not a tree: 4e9e0ee19b60b13eb79915933f44d8ed5f268bdd
Failed to run 'git checkout 4e9e0ee19b60b13eb79915933f44d8ed5f268bdd' for 'mdns-publisher': Exited with code 128.
Verify that the part is using the correct parameters and try again.
Exited with code exit status 2
Huh. That commit isn't anywhere in my project or my dependencies. Turns out it's actually in the godeps plugin itself, when it's trying to checkout go-toml:
https://github.com/snapcore/snapcraft/blob/a6dfe1cd2c0457ea48940cbec84762e91bce4edb/snapcraft/plugins/v1/godeps.py#L134
It looks like that commit hash may no longer exist. This seems like a rather fragile way to do things, but we must have done it for a reason I don't understand. Is it something we can improve upon?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution. The hardcoded commit hash in the godeps plugin causing checkout failures was not addressed, likely abandoned or superseded by newer plugin versions. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
95
Complexity:
40
Confidence:
85
Support Request:
10
|
close stale | Reports a failing git checkout due to an invalid commit hash in the snapcraft godeps plugin. Unlabeled, no maintainer response, and over five years old. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
98
Complexity:
30
Confidence:
85
Support Request:
5
|
close stale | CI failure in snapcraft's godeps plugin due to an invalid commit hash for go-toml. Unlabeled, no maintainer response, inactive for over 5 years. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
95
Complexity:
50
Confidence:
85
Support Request:
10
|
needs triage | The snapcraft godeps plugin uses a hardcoded, likely invalid commit hash for go-toml, causing git checkout failures. Untriaged with no maintainer response after over five years. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
95
Complexity:
30
Confidence:
85
Support Request:
10
|
close stale | The snapcraft godeps plugin relies on a hardcoded, likely expired commit hash for go-toml, causing checkout failures. Issue is open, unassigned, and requires triage to replace the fragile hash lookup with a more robust dependency resolution method. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1748202 go plugin doesn't honor godeps file | snapcraft (launchpad) | closed | The go plugin fails to parse Godeps files for dependency versioning, causing build errors. The issue was closed without resolution, indicating it was abandoned. |