← Back to issue list

copy plugin doesn't handle directories

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1478052
Type
issue
State
closed
Author
~mterry
Labels
first-steps
Created
Updated
Closed

Current evaluation

Launchpad bug migrated to ubuntu-core/snapcraft#16 and closed: copy plugin already handled directory sources; PR #87 (commit 918627069, merge ebf55e30d) added a passing integration test confirming it.

Resolution: closed not a bug

Reason: Directory sources were already supported by the copy plugin, so no code fix was needed. The behaviour was verified by the integration test added in ubuntu-core/snapcraft PR #87 (commit 918627069, merged via ebf55e30d), after which elopio closed the issue on 2015-11-23 noting that since the test passes, a fix must exist.

Evaluated by: mr-cal-bot

No scores available.

Issue body

I thought we had written the copy plugin to handle directories as a src file. i.e. the following would work: parts: test: plugin: copy files: bin: . But it seems it does not. It should!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed not a bug Launchpad bug migrated to ubuntu-core/snapcraft#16 and closed: copy plugin already handled directory sources; PR #87 (commit 918627069, merge ebf55e30d) added a passing integration test confirming it.
stealth/space-bunny-alpha — closed resolved Directory sources are supported by the copy plugin; merged PR #87 added a passing regression test confirming the fix.
stealth/space-bunny-alpha — closed resolved Directory-source support was confirmed by regression tests merged in PR #87 (918627069; merge ebf55e30d), with no further code change needed because the behavior was already fixed.
qwen/qwen3.6-35b-a3b — — Abandoned. The copy plugin fails to handle directories as source files, but no fix, rejection, or superseding action was recorded due to zero comments and inactivity.
qwen/qwen3.6-35b-a3b — — Closed without resolution or comments, indicating the issue was abandoned. The copy plugin was reported to fail handling directories as source files, but no fix was implemented.

Update history

Date Change
created

Related work

  • Superseded By: canonical/snapcraft#16 (confidence 97%)

    elopio moved the Launchpad bug to GitHub issue ubuntu-core/snapcraft#16 on 2015-10-30

  • Related To: canonical/snapcraft#87 (confidence 95%)

    PR 'copy-dirs' by ted-gould added an integration test covering directory sources in the copy plugin; merged as ebf55e30d with test commit 918627069

Related issues

Issue Project State Summary Similarity
#16 copy plugin doesn't handle directories snapcraft closed Directory sources were already supported; PR #87 added regression coverage confirming the copy plugin handles them and was merged in 918627069 (merge ebf55e30d).
85%
#87 A test for directories in the copy plugin snapcraft merged Merged in canonical/snapcraft#87 (commit 918627069; merge ebf55e30d), adding regression coverage confirming copy-plugin directories work after the earlier #16 fix.
81%
#1478054 copy plugin doesn't support globs snapcraft (launchpad) closed Launchpad bug 1478054 (copy plugin lacks src glob support) was migrated to GitHub issue ubuntu-core/snapcraft#26 and fixed by merged PR #108, commit 8294647d6, which replaced cp with Python glob calls and added a unit test.
77%
#809 make plugin: improve artifact copying (LP: #1624798) snapcraft merged Merged in canonical/snapcraft#809 via e9a495809, improving make-plugin artifact copying to support directories and address LP #1624798.
73%
#1624798 make plugin: can't copy directories or nested artifacts snapcraft (launchpad) closed Fixed in snapcore/snapcraft#809 (commit e9a495809): the make plugin now copies directory and individual artifact files into the snap.
71%
#1559154 Copy plugin should support sources snapcraft (launchpad) closed Source support was added to the Copy plugin by canonical/snapcraft PR #416, merged as commit 9a6684ce7.
70%
#26 copy plugin doesn't support globs snapcraft closed Copy-plugin source globs were implemented by merged PR #108 (commit 8294647d6, merge 639d60c41); tracking later moved back to Launchpad.
70%