The local source pull is not fully covered by unittests
Metadata
Current evaluation
Maintainer ~elopio's own test-debt bug for the uncovered branch in local source pulling (duplicated os.remove logic) was closed after ubuntu-core/snapcraft PR #262 refactored the pull and added full unit-test coverage; merged as 3d0e49c4c.
Resolution: closed resolved
Reason: The issue's sole comment links ubuntu-core/snapcraft PR #262, which was merged (merge commit 3d0e49c4c, refactor commit 70d51290e) refactoring the local source pull, removing the duplicated os.remove logic and adding the missing unit-test coverage.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Maintainer ~elopio's own test-debt bug for the uncovered branch in local source pulling (duplicated os.remove logic) was closed after ubuntu-core/snapcraft PR #262 refactored the pull and added full unit-test coverage; merged as 3d0e49c4c. | |
| stealth/space-bunny-alpha | — | closed resolved | Resolved by merged PR #262, which refactored the local source pull, removed duplicated os.remove logic, and added complete unit-test coverage (merge 3d0e49c4c). | |
| stealth/space-bunny-alpha | — | closed stale | Closed without a documented fix after roughly 3,894 days; no comments, resolving PR, or commit are linked to the reported test gap and duplicated os.remove logic. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned without resolution. The maintainer noted missing unit test coverage for local source pulls and redundant os.remove logic in conditional blocks. No fix or pull request was submitted. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution or linked pull request. The report identified missing unit test coverage for local source pull operations and redundant os.remove calls in conditional logic. The issue was abandoned without a fix. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The report identified missing unit test coverage and redundant os.remove calls in the local source pull logic. No follow-up or code changes were made. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution or follow-up. The report identified missing unit test coverage and duplicated os.remove logic in the local source pull implementation. No fix or merge details were recorded. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcraft#262
(confidence 95%)
Merged PR referenced in the closing comment; refactored local source pull and added full test coverage.
-
Related To:
snapcraft (launchpad)#1558446
(confidence 45%)
Related Launchpad bug on local source pulling behaviour, fixed separately by PR #377; shares the same code path but not this test-debt item.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1558446 Pulling local sources is rather broken | snapcraft (launchpad) | closed | Local source pull bug fixed by ubuntu-core/snapcraft PR #377 (commit eb6ad38ab "Correct local source pulling", merged as 8b4a18d9b), which inverts the isdir/rmdir checks so symlinked local sources are removed rather than raising. | |
| #262 Refactored the local source pull. | snapcraft | merged | Merged PR #262 refactored local source pulling and added full test coverage in commit 70d51290e; merge commit: 3d0e49c4c. |