← Back to issue list

catkin plugin uses unhashables for dependencies

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1552498
Type
issue
State
closed
Author
~sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Fixed the Catkin unhashable-list dependency error by merging ubuntu-core/snapcraft#363 in commit 8add8448b.

Resolution: closed resolved

Reason: The issue was closed after PR #363 was merged; the fix was recorded in commit 8add8448b.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Determining system dependencies for Catkin packages... Traceback (most recent call last): File "../../bin/snapcraft", line 31, in <module> snapcraft.main.main() File "/home/sergiusens/source/github.com/ubuntu-core/snapcraft/snapcraft/main.py", line 122, in main commands.load(cmd).main(argv=args['ARGS']) File "/home/sergiusens/source/github.com/ubuntu-core/snapcraft/snapcraft/commands/snap.py", line 72, in main snap = lifecycle.execute('strip') File "/home/sergiusens/source/github.com/ubuntu-core/snapcraft/snapcraft/lifecycle.py", line 53, in execute _Executor(config).run(step, part_names) File "/home/sergiusens/source/github.com/ubuntu-core/snapcraft/snapcraft/lifecycle.py", line 80, in run self._run_step(step, part, part_names, dirty, recursed) File "/home/sergiusens/source/github.com/ubuntu-core/snapcraft/snapcraft/lifecycle.py", line 104, in _run_step getattr(part, step)() File "/home/sergiusens/source/github.com/ubuntu-core/snapcraft/snapcraft/pluginhandler.py", line 146, in pull self.code.pull() File "/home/sergiusens/source/github.com/ubuntu-core/snapcraft/snapcraft/plugins/catkin.py", line 196, in pull system_dependencies.add(roscore_dependency) TypeError: unhashable type: 'list'

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed the Catkin unhashable-list dependency error by merging ubuntu-core/snapcraft#363 in commit 8add8448b.
stealth/space-bunny-alpha — closed resolved Fixed the Catkin dependency TypeError by merging PR #363 in commit 8add8448b.
stealth/space-bunny-alpha — closed resolved Catkin dependency handling was fixed to use hashable entries when populating the system-dependency set, preventing the reported unhashable-list TypeError. Launchpad bug 1552498 is closed.
qwen/qwen3.6-35b-a3b — — Fixed a TypeError in the catkin plugin where a list was incorrectly added to a set. The code was updated to unpack or convert dependencies to hashable types, resolving the crash during system dependency resolution.
qwen/qwen3.6-35b-a3b — — Fixed by correcting the unhashable list type error in the catkin plugin's system dependency handling, resolving the TypeError during snapcraft execution.
qwen/qwen3.6-35b-a3b — — Fixed by correcting the unhashable list type error in the catkin plugin. The bug caused a TypeError when adding system dependencies to a set. Resolved by ensuring hashable types are used.
qwen3.6-35b-a3b-mtp-q6 — — Fixed a catkin plugin crash where list dependencies caused a TypeError when added to a set. The code was updated to handle unhashable types, resolving the dependency resolution failure. Issue closed.

Update history

Date Change
created

Related work

  • Likely Fixed By: ubuntu-core/snapcraft#363 (confidence 100%)

    The linked pull request resolved the TypeError by correcting Catkin dependency handling.

Related issues

Issue Project State Summary Similarity
#1548406 Catkin plugin: Can't handle rosdep resolving to nothing snapcraft (launchpad) closed Fixed by canonical/snapcraft#331, merged as commit 1c1119ce3; Catkin now treats empty rosdep output as no dependencies instead of an error.
73%
#1548404 Catkin plugin: Can't handle rosdep resolving to multiple packages snapcraft (launchpad) closed Fixed by ubuntu-core/snapcraft PR #331 (commit 1c1119ce3, 'Catkin plugin: Handle rosdep empty and multiple dependencies'), merged as e3a2b9d03; maintainer ~kyrofa linked the PR when closing the Launchpad bug.
71%
#1571446 catkin plugin fails to work snapcraft (launchpad) closed Catkin repository setup was migrated to ProjectOptions by merged PR ubuntu-core/snapcraft#468 (commit 77b0f9c26), fixing the plugin failure.
70%
#1548370 Catkin plugin: Confusing print when dependency is an invalid package snapcraft (launchpad) closed Catkin now reports a clear error for invalid dependency packages; fixed by merged canonical/snapcraft PR #330 (e44ded923).
70%