← Back to issue list

nodejs plugin: Unable to use node version other than 4.2.2

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1586104
Type
issue
State
closed
Author
~kyrofa
Labels
verification-done
Created
Updated
Closed

Current evaluation

nodejs plugin's hard-coded node 4.2.2 made configurable via a new `node-engine` key; implemented in snapcraft PR #509 (commit d579b556e), released in snapcraft 2.10 and verified in xenial-proposed.

Resolution: closed resolved

Reason: Feature PR ubuntu-core/snapcraft#509 (commit d579b556e, 'nodejs plugin: Support configurable node version') made the node version configurable via `node-engine`. The fix shipped in package snapcraft 2.10+16.10 and was confirmed by elopio in xenial-proposed (node 4.4.2 selected via node-engine), after which the bug was tagged verification-done and closed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

[Impact] * The nodejs plugin is hard-coded to use version 4.2.2. This should be configurable via a `node-engine` config parameter. [Test Case] 1. Run `snapcraft` on the shout example, notice by default it uses the node LTS (v4.4.4). 2. Run `snapcraft clean` to reset the shout example. 3. Change the shout configuration to specify `node-engine: 4.2.2`. 4. Run `snapcraft` on the shout example again, noticing that it's now using node v4.2.2. [Regression Potential] * Very low. This is a new feature that maintains backward compatibility with the previous plugin.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved nodejs plugin's hard-coded node 4.2.2 made configurable via a new `node-engine` key; implemented in snapcraft PR #509 (commit d579b556e), released in snapcraft 2.10 and verified in xenial-proposed.
stealth/space-bunny-alpha — closed resolved Nodejs plugin's hard-coded 4.2.2 made configurable via new node-engine key. Merged in snapcraft#509 (d579b556e), shipped in snapcraft 2.10; verification-done after xenial-proposed test confirmed node 4.4.2 use.
stealth/space-bunny-alpha — closed resolved Fixed by adding configurable node-engine support in PR #509 (commit d579b556e), replacing the hard-coded Node 4.2.2 default.
qwen/qwen3.6-35b-a3b — — Resolved by adding a configurable node-engine parameter to the nodejs plugin, replacing the hard-coded v4.2.2 default. Implementation verified and closed.
qwen/qwen3.6-35b-a3b — — Fixed by implementing a configurable node-engine parameter in the nodejs plugin, replacing the hard-coded 4.2.2 version. The change maintains backward compatibility and was verified before closing.
qwen/qwen3.6-35b-a3b — — Fixed by adding a configurable node-engine parameter to the nodejs plugin, replacing the hard-coded v4.2.2 default. The change was verified and the issue closed.
qwen3.6-35b-a3b-mtp-q6 — — Implemented configurable node-engine parameter in the nodejs plugin, replacing the hard-coded 4.2.2 version. Verified and closed.

Update history

Date Change
created

Related work

  • Likely Fixed By: ubuntu-core/snapcraft#509 (confidence 97%)

    Merged PR adding node-engine config option to the nodejs plugin; commit d579b556e.

  • Related To: snapcraft (launchpad)#1586504 (confidence 15%)

    Same 2.10+16.10 SRU changelog batch, but unrelated auth/config change (login/logout client).

Related issues

Issue Project State Summary Similarity
#509 Add node-engine to snapcraft.yaml snapcraft merged Merged configurable node-engine support in #509 (commit d579b556e), replacing the Node.js plugin's hardcoded 4.2.2; shipped in Snapcraft 2.10.
76%
#1838474 nodejs plugin assumes a version key in the package.json snapcraft (launchpad) open Legacy nodejs plugin crashed when package.json omitted its optional version field; active Snapcraft now uses the npm plugin and no longer contains that implementation.
72%