All the unit tests start a fake parts server
Metadata
Current evaluation
Fixed in snapcraft#720 via commit dd5116ade, which starts the fake parts server only for unit tests that need it; the fix was reviewed and verified.
Resolution: closed resolved
Reason: Commit dd5116ade, titled "Start the fake parts server only in the tests that need it," resolves the performance issue and cites PR #720. The maintainer later marked the fix verified after PR review and a successful Debian build.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The base class for all unit tests is starting a local server for the parts index, even for the tests that don't need it.
This makes the suite slower.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Fixed in snapcraft#720 via commit dd5116ade, which starts the fake parts server only for unit tests that need it; the fix was reviewed and verified. | |
| stealth/space-bunny-alpha | — | closed resolved | Fake parts-server startup was made opt-in for unit tests in PR #720 (commit dd5116ade), removing unnecessary local servers and speeding up the suite. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed by merged PR #720 (commit dd5116ade), making remote-part loading lazy so the fake parts server starts only for tests that need it. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed by modifying the unit test base class to conditionally start the fake parts server only when required, reducing suite execution time. Marked verification-done. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed and verified. Removed unnecessary fake parts server startup from the base test class, optimizing the unit test suite and reducing execution time. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed by removing the unnecessary fake parts server startup from the base test class, improving suite performance. Verified and closed. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcraft#720
(confidence 100%)
PR #720 produced resolving commit dd5116ade with the exact optimization described by the issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #720 Start the fake parts server only in the tests that need it | snapcraft | merged | Merged PR #720 in commit dd5116ade, making remote-part loading lazy and starting the fake parts server only for tests that require it. | |
| #640 Setup the FakeParts store for all unit tests | snapcraft | merged | Merged PR #640 as a119759b8, adding FakeParts setup to five unit-test files so remote-parts tests initialize a consistent cache. | |
| #46 tests: add fake snapd fixture | craft-parts | merged | Merged PR #46 as 64fdf574 (feature commit 9db65074), adding a 212-line fake snapd fixture for testing snap package handling in craft-parts.packages. | |
| #1600273 Add missing FakeParts | snapcraft (launchpad) | closed | Missing FakeParts fixtures implemented via snapcore/snapcraft PR #640, merged as commit a119759b8 "Setup the FakeParts store for all unit tests"; maintainer sergiusens closed the bug pointing to that PR. |