← Back to issue list

You can close a channel that hasn't been opened

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1695242
Type
issue
State
open
Author
~elopio
Labels
store ui
Created
Updated
Closed
—

Current evaluation

snapcraft close reports success for channels that were already closed or never opened; the current command still emits that unconditional success message

Suggested action: keep open

Reason: The maintainer-authored report has store and UI labels and provides a complete reproducer. At the current revision, StoreCloseCommand calls client.close() and unconditionally prints that the channel "is now closed"; fixing this requires determining or reporting the channel's prior/post-close state and adding tests for open, already-closed, and never-opened cases.

Evaluated by: mr-cal-bot

Impact: 32 Quick Win: 17 Complexity: 38 Confidence: 96 Actionability: 87

Issue body

When I run snapcraft close on a snap and channel that have no revision, snapcraft just says that the channel has been closed. This is inaccurate, as the channel was already closed before, or haven't been opened. To reproduce: $ snapcraft init Rename the snap to something unique. $ snapcraft $ snapcraft push *.snap $ snapcraft close my-snap edge Track Arch Channel Version Revision The edge channel is now closed. $ snapcraft close my-snap edge Track Arch Channel Version Revision The edge channel is now closed. $ snapcraft close my-snap edge Track Arch Channel Version Revision The edge channel is now closed.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 32
Quick Win: 17
Complexity: 38
Confidence: 96
Actionability: 87
keep open snapcraft close reports success for channels that were already closed or never opened; the current command still emits that unconditional success message
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 20
Complexity: 15
Confidence: 85
Actionability: 80
keep open snapcraft close reports success even when channel is already closed or never opened, giving inaccurate feedback to the user.
qwen/qwen3.8-27b
Impact: 30
Quick Win: 21
Staleness: 25
Complexity: 30
Confidence: 55
Support Request: 10
keep open snapcraft close reports 'channel is now closed' even when the channel was never opened or already closed, which is inaccurate. Open since 2017, no comments, but recently active (17 days ago) and labelled store/ui by a maintainer.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 25
Confidence: 90
Support Request: 5
close stale Reports snapcraft close incorrectly confirms success when closing an already closed or unopened channel. Provides reproduction steps. Inactive for over 9 years with no maintainer response.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 25
Confidence: 90
Support Request: 5
close stale snapcraft close reports success even when a channel was never opened or already closed. Reported over nine years ago with zero maintainer interaction.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 20
Confidence: 80
Support Request: 10
close stale snapcraft close reports success on unopened channels without revisions, showing a misleading confirmation message. Issue remains open with no maintainer response for over 9 years.
qwen3.6-35b-a3b-mtp-q6
Staleness: 98
Complexity: 20
Confidence: 85
Support Request: 5
close stale snapcraft close incorrectly reports success when closing an unopened channel with no revisions. Issue is 9 years old, has zero comments, and likely reflects outdated CLI behavior.

Update history

Date Change
created

Related issues

No related issues found above the similarity threshold.