← Back to issue list

New git commits don't mark pull step dirty

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1704103
Type
issue
State
open
Author
~saviq
Labels
—
Created
Updated
Closed
—

Current evaluation

New commits intentionally do not dirty a source-type: git pull step; maintainers redirected automatic source tracking toward source-type: local.

Suggested action: close not a bug

Reason: @~sergiusens explicitly agreed to treat these parts as dependencies, noting that new stage-packages also do not dirty the build, and said implementation would focus on source-type: local first. Current craft-parts also implements outdated checking for LocalSource but not GitSource, confirming that the reported Git-source behavior remains intentional.

Evaluated by: mr-cal-bot

Impact: 30 Quick Win: 19 Complexity: 25 Confidence: 95 Actionability: 85

Issue body

Given a part: foo: plugin: dump source: . source-type: git $ snapcraft Preparing to pull foo Pulling foo Preparing to build foo Building foo Staging foo Priming foo [...] $ git commit -m test --unchanged $ snapcraft Skipping pull foo (already ran) [...]

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 30
Quick Win: 19
Complexity: 25
Confidence: 95
Actionability: 85
close not a bug New commits intentionally do not dirty a source-type: git pull step; maintainers redirected automatic source tracking toward source-type: local.
stealth/space-bunny-alpha
Impact: 38
Quick Win: 12
Complexity: 55
Confidence: 91
Actionability: 70
keep open New commits to a local Git source can leave the pull step cached, producing a stale build; maintainers deferred Git tracking as dependency-like while prioritizing local-source updates.
stealth/space-bunny-alpha
Impact: 48
Quick Win: 17
Complexity: 51
Confidence: 94
Actionability: 72
keep open Local Git sources still skip pull after new commits; maintainers acknowledged the case as dependency-like and deferred it while prioritizing update detection for local sources.
qwen/qwen3.6-35b-a3b
Impact: 65
Quick Win: 29
Complexity: 45
Confidence: 75
Actionability: 80
keep open Git source with local path doesn't detect upstream commits, skipping pull step. Valid bug in craft-parts git source handler.
qwen/qwen3.8-27b
Impact: 55
Quick Win: 30
Staleness: 95
Complexity: 45
Confidence: 55
Support Request: 10
needs triage Snapcraft skips the pull step for git-source parts after new commits, using stale source. Reported 9 years ago with clear repro; no labels, comments, or maintainer interaction since.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 45
Confidence: 90
Support Request: 10
close stale Snapcraft incorrectly skips the pull step after new git commits are made, failing to invalidate the build cache. The issue has been inactive for nearly 9 years with no maintainer response.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 25
Confidence: 85
Support Request: 5
close stale Snapcraft git source dirty state detection fails to trigger pull step after new commits. Issue is 9 years old with no maintainer response or comments.
qwen3.6-35b-a3b-mtp-q6
Staleness: 98
Complexity: 45
Confidence: 85
Support Request: 5
close stale Bug report stating snapcraft skips the pull step after new git commits. Issue is 9 years old, has no comments or labels, and is likely irrelevant due to major snapcraft build system rewrites.

Update history

Date Change
created

Related issues

No related issues found above the similarity threshold.