← Back to issue list

Better base detection

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1795501
Type
issue
State
closed
Author
~sergiusens
Labels
18.10-build-vm
Created
Updated
Closed

Current evaluation

Build-environment base detection was fixed by merged PR #2309 (commit 3565ed2e7); PR #2311 also corrected legacy re-exec behavior.

Resolution: closed resolved

Reason: PR #2309 merged as commit 3565ed2e7, allowing base detection outside the project directory. PR #2311 was also merged to ensure legacy Snapcraft re-exec used the correct interpreter.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The current base detection logic in bin/snapcraft fails to work inside a build environment as it expectes snapcraft.yamls in $PWD.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Build-environment base detection was fixed by merged PR #2309 (commit 3565ed2e7); PR #2311 also corrected legacy re-exec behavior.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #2309 (commit 3565ed2e7), with PR #2311 also merged for legacy re-exec behavior; build-environment base detection now works outside the project directory.
stealth/space-bunny-alpha — closed resolved Base detection was fixed for build environments by merged PR canonical/snapcraft#2309, handling project files outside $PWD (commit 3565ed2e7).
qwen/qwen3.6-35b-a3b — — Abandoned. Closed without comments or resolution. The base detection failure in snapcraft build environments was not addressed.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The base detection logic issue remains unaddressed and appears abandoned due to extended inactivity and lack of comments.
qwen/qwen3.6-35b-a3b — — Closed without resolution or comments. Likely abandoned due to inactivity. The original report noted snapcraft failing to locate snapcraft.yaml in build environments.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned and closed without resolution. The base detection failure in build environments, caused by incorrect $PWD expectations in bin/snapcraft, received no follow-up or fix.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcraft#2309 (confidence 100%)

    Merged PR that fixed early base detection in build providers outside the project directory.

  • Related To: snapcraft#2311 (confidence 95%)

    Merged follow-up correcting legacy Snapcraft re-exec behavior.

Related issues

Issue Project State Summary Similarity
#4343 feat(remote-build): check base before executing snapcraft merged Merged into main as commit 128e0acb2. Added base validation before remote-build, allowing fallback for core20/core22 while rejecting unsupported bases and fixing #4318.
72%
#274 bases: refactor base handling code craft-providers merged Merged PR #274 as commit b72f04c, refactoring base handling, moving instance configuration, adding per-operation executor timeouts, and standardizing shared base-image contents.
72%
#2309 snap: improve early base detection logic snapcraft merged Merged PR #2309 (commit 3565ed2e7), fixing early base detection when Snapcraft runs in a build provider outside the project directory (LP #1795501).
71%
#247 bases: refactor buildd to ubuntu craft-providers merged Merged PR #247 as de2d42e, replacing Buildd-specific base handling with Ubuntu-specific modules and preparing base dispatch for additional OS support.
70%