← Back to issue list

improve cleanbuild backwards compatibilty

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1803193
Type
issue
State
closed
Author
~sergiusens
Labels
18.10-build-vm
Created
Updated
Closed

Current evaluation

Fixed by adding hidden cleanbuild YAML validation in snapcore/snapcraft#2404 (commit 248fe265d).

Resolution: closed resolved

Reason: PR snapcore/snapcraft#2404 addressed the compatibility problem and was recorded as commit 248fe265d, titled "cli: handle yaml errors for cleanbuild (#2404)". The maintainer linked this resolving PR on the issue.

Evaluated by: mr-cal-bot

No scores available.

Issue body

when using cleanbuild, if the yaml is invalid, the new codebase handles the cli which will not work correctly given that the command no longer exists. Add a thin hidden cleanbuild click command that performs a validation for invalid yaml and fails appropriately when used with bases.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by adding hidden cleanbuild YAML validation in snapcore/snapcraft#2404 (commit 248fe265d).
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/snapcraft#2404, adding YAML error handling and tests for the legacy cleanbuild CLI command.
stealth/space-bunny-alpha — closed stale Requested a hidden cleanbuild command to catch invalid YAML and fail correctly with bases; closed without a documented fix or linked PR.
stealth/space-bunny-alpha — closed resolved Added YAML validation and appropriate failure handling for the hidden cleanbuild compatibility command; merged in PR #2404 as 248fe265d.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The proposed hidden cleanbuild command for YAML validation was not added, likely abandoned or superseded by later CLI changes.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The proposed hidden cleanbuild command for YAML validation was not addressed, indicating the backwards compatibility fix was abandoned or superseded.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The proposed hidden click command for YAML validation and backwards compatibility was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Fixed by adding a hidden cleanbuild click command that validates YAML and fails appropriately when used with bases, restoring backwards compatibility.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#2404 (confidence 100%)

    The linked PR added cleanbuild handling for YAML errors and was committed as 248fe265d.

Related issues

Issue Project State Summary Similarity
#1796980 Remove cleanbuild snapcraft (launchpad) closed Merged snapcore/snapcraft#2335 as 27ec9ba63, removing LXD lifecycle builds for base-based snaps and making cleanbuild redundant for them.
73%
#1593529 The cleanbuild integration test is skipped snapcraft (launchpad) closed Cleanbuild integration testing was re-enabled by snapcore/snapcraft#1610, merged as commit e38921ab3.
72%
#1609803 snapcraft cleanbuild --no-clean-up snapcraft (launchpad) closed Cleanbuild debugging landed in snapcore/snapcraft PR #740 (commit a24083e75); follow-up PR #1404 made --debug enter a shell when builds fail.
71%
#3105 build provider: clean incompatible build-environments snapcraft merged Merged #3105 as f1119fd03, rebuilding build instances when base metadata is missing or the instance came from an incompatible or legacy Snapcraft version; compatibility tests were updated.
71%