← Back to issue list

gradle plugin: update gradle plugin to support both gradle and gradlew

View original Github issue

Metadata

Project
snapcraft
Number
#1024
Type
pull request
State
merged
Author
ZenHarbinger
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #1024 (commit 8f601ff93): Gradle builds now use ./gradlew when present, otherwise system Gradle, with configurable output directories and expanded tests.

Resolution: closed resolved

Reason: PR #1024 was merged as commit 8f601ff93, adding wrapper/system Gradle detection and a configurable Gradle output directory.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Updated gradle plugin to check if ./gradlew exists in os.cwd(). If it does not, then 'gradle' is added to the get_build_dependencies() list. If it does, then ./gradlew is called, if it does not, then gradle is called. Updated tests to use both gradle and gradlew (so a complete duplication of all tests). Added an option to specify the gradle-output-dir which will by copied to the installdir. The default value here is 'build/libs' which is what the old default was hard-coded to be. https://bugs.launchpad.net/snapcraft/+bug/1653182

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #1024 (commit 8f601ff93): Gradle builds now use ./gradlew when present, otherwise system Gradle, with configurable output directories and expanded tests.
stealth/space-bunny-alpha — closed resolved Merged in #1024 (commit 8f601ff93): Gradle builds now use ./gradlew when present, otherwise system Gradle, with configurable output directories and expanded tests.
stealth/space-bunny-alpha — closed resolved Merged #1024: Gradle now uses gradlew when present or falls back to gradle, with configurable output-directory support and tests for both workflows.
qwen/qwen3.6-35b-a3b — — Merged update to the Gradle plugin enabling support for both gradle and gradlew via wrapper detection, adding a configurable output directory, and expanding tests. Successfully merged after CLA verification and reviewer approval.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Updates the Gradle plugin to detect and use gradlew when available, falling back to gradle otherwise. Adds a configurable gradle-output-dir option and updates tests. Approved after CLA verification and code coverage checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1653182 plugin: update gradle plugin to support gradle and gradlew snapcraft (launchpad) closed System Gradle and gradlew support, configurable output directories, and expanded tests were merged in snapcore/snapcraft#1024 via commit 8f601ff93.
79%