local source: preserve symlinks to directories.
Metadata
Current evaluation
Merged to preserve symlinks to directories in local sources instead of creating new directories, fixing Launchpad bug #1659653. Approved and merged after PR #1083 to group similar changes.
Suggested action: —
No scores available.
Issue body
This PR fixes LP: [#1659653](https://bugs.launchpad.net/snapcraft/+bug/1659653) by preserving any symlinks to directories within local sources instead of creating a new directory.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to preserve symlinks to directories in local sources instead of creating new directories, fixing Launchpad bug #1659653. Approved and merged after PR #1083 to group similar changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after PR #1083 to group similar changes. Fixes LP #1659653 by preserving symlinks to directories in local sources instead of recreating them. Code coverage stayed above 96%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master to fix Launchpad bug #1659653. Preserves symlinks to directories in local sources instead of recreating them. Merged after PR #1083 per maintainer request. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #622 Hard-link local sources instead of symlinking them. | snapcraft | merged | Merged. Fixes LP #1590108 by hard-linking local sources instead of symlinking, with a fallback to copying if hard links are unsupported. Review comments were addressed and CI coverage fluctuations resolved prior to merge. | |
| #377 Correct local source pulling | snapcraft | merged | Merged fix for local source pulling that incorrectly followed symlinks, causing rmdir failures and duplicate pull errors. The change inverts the directory check, adds explicit symlink validation, and improves error handling. Approved by @zyga. Resolves LP: #1558446. |