Don't wait for lxd networking in cleanbuild test
Metadata
Current evaluation
Merged to master. Removed an unnecessary LXD networking wait in the cleanbuild test, cutting runtime by five seconds. Approved by two reviewers, passed CI, and integrated successfully.
Suggested action: —
No scores available.
Issue body
It's not relevant to the test. This strips 5 seconds off the test
run-time.
Checklist:
- Have you signed the contributor licence agreement?
https://www.ubuntu.com/legal/contributors
I assume being a Canonical employee is sufficient?
- Is there a reported a bug for the problem you are fixing?
Given this is a test cleanup, I'm assuming I don't need one.
- Have you read our contribution guide?
[CONTRIBUTING.md](CONTRIBUTING.md)
I have now!
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to master. Removed an unnecessary LXD networking wait in the cleanbuild test, cutting runtime by five seconds. Approved by two reviewers, passed CI, and integrated successfully. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a test cleanup that removes an unnecessary five-second wait for LXD networking in the cleanbuild test, reducing execution time. Approved by maintainers and passed code coverage checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a test optimization removing an unnecessary LXD networking wait in the cleanbuild test, reducing runtime by five seconds. Approved by maintainers and passed code coverage checks. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3033 build providers: do not print network test output for LXD | snapcraft | merged | Merged changes to suppress network test output during LXD environment setup. The update modifies two files to prevent printing getent hosts snapcraft.io results, passed CI checks, and received reviewer approval. | |
| #2557 ci: remove dependency on LXD from travis tests | snapcraft | merged | Merged into master, removing the LXD dependency from Travis CI tests to reduce networking errors. Approved, passed CI checks, and modified two files without impacting code coverage. | |
| #1807 tests: run test_cleanbuild in LXD on Travis | snapcraft | merged | Merged following CI errors and reviewer feedback. Adjusted to run test_cleanbuild in LXD on Travis, reverting a problematic commit to isolate the cleanbuild fix. | |
| #328 New command cleanbuild (using lxd) | snapcraft | merged | Merged a new cleanbuild command using LXD for isolated builds. pylxd was removed due to API changes and Python 3 compatibility, and integration tests were skipped. Approved and merged by maintainers. | |
| #2966 build providers: move to buildd images | snapcraft | merged | Merged. Moves build providers to buildd images, enabling multi-architecture and core20 support for LXD. Approved, passed CI, and addressed reviewer feedback on network wait logic. | |
| #3112 spread: remove dead code for lxd setup and add debug prints | snapcraft | merged | Merged removal of redundant elif dead code in LXD setup logic and addition of debug prints for LXD snap install failures. Approved by one reviewer, passed CI checks, and integrated. | |
| #1230 lxd: refactor Cleanbuilder into Containerbuild and add Project. | snapcraft | merged | Merged. Refactored Cleanbuilder into a Containerbuild base class and introduced a Project class to manage persistent LXD containers for snap builds. Approved after code review and test fixes. |