← Back to issue list

Don't wait for lxd networking in cleanbuild test

View original Github issue

Metadata

Project
snapcraft
Number
#1087
Type
pull request
State
merged
Author
OddBloke
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1087 (commit 01a17282b) removed an unnecessary LXD networking wait from the cleanbuild test, cutting about five seconds from runtime.

Resolution: closed resolved

Reason: The approved one-line test cleanup was merged as commit 01a17282b, eliminating the irrelevant LXD networking wait and shortening the test run by roughly five seconds.

Evaluated by: mr-cal-bot

No scores available.

Issue body

It's not relevant to the test. This strips 5 seconds off the test run-time. Checklist: - Have you signed the contributor licence agreement? https://www.ubuntu.com/legal/contributors I assume being a Canonical employee is sufficient? - Is there a reported a bug for the problem you are fixing? Given this is a test cleanup, I'm assuming I don't need one. - Have you read our contribution guide? [CONTRIBUTING.md](CONTRIBUTING.md) I have now!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1087 (commit 01a17282b) removed an unnecessary LXD networking wait from the cleanbuild test, cutting about five seconds from runtime.
stealth/space-bunny-alpha — closed resolved Merged #1087 via commit 01a17282b, removing the unnecessary LXD network wait from the cleanbuild test and cutting about 5 seconds from runtime.
stealth/space-bunny-alpha — closed resolved Merged PR #1087, removing the LXD networking wait from the cleanbuild test and cutting about five seconds from runtime (commit 01a17282b).
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#1087 by OddBloke, removing an unnecessary wait for LXD networking from the cleanbuild test to cut ~5s from test runtime; merged as commit 01a17282b.
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#1087 to remove an unnecessary LXD networking wait from the cleanbuild test, reducing its runtime by about 5 seconds.
stealth/space-bunny-alpha — closed resolved Merged PR #1087 removed an unnecessary LXD networking wait from the cleanbuild test, cutting its runtime by five seconds. Approved by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged to master. Removed an unnecessary LXD networking wait in the cleanbuild test, cutting runtime by five seconds. Approved by two reviewers, passed CI, and integrated successfully.
qwen3.6-35b-a3b-mtp-q6 — — Merged a test cleanup that removes an unnecessary five-second wait for LXD networking in the cleanbuild test, reducing execution time. Approved by maintainers and passed code coverage checks.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.