← Back to issue list

core: classic with no exported variables.

View original Github issue

Metadata

Project
snapcraft
Number
#1090
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged and superseded by snapcraft#1093, which implemented the classic-confinement fix in commit e7824093f for LP #1657504.

Resolution: closed superseded

Reason: The maintainer said #1090 might be replaced by #1093. That PR subsequently merged as commit e7824093f with the classic-confinement and environment-isolation changes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

To avoid unexpected errors we wipe clean the envrionment variables inside the wrappers, if a developer needs it they could export it themselves. LP: #1657504 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by snapcraft#1093, which implemented the classic-confinement fix in commit e7824093f for LP #1657504.
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by #1093, merged as e7824093f with the Python-plugin classic-confinement fix for LP #1657504.
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by snapcraft#1093, which merged the Python plugin's classic-confinement fix for LP #1657504 in commit e7824093f.
stealth/space-bunny-alpha — closed superseded Closed unmerged; its classic-environment cleanup was superseded by snapcraft#1093, which merged the Python plugin’s classic-confinement changes for LP #1657504.
qwen/qwen3.6-35b-a3b — — Closed without merging. The author noted the changes would be handled by pull request #1093, superseding this PR. The update aimed to clear environment variables in wrappers to prevent unexpected errors.
qwen3.6-35b-a3b-mtp-q6 — — PR #1090 removed exported environment variables from wrappers. After a minor Codecov coverage drop, the author indicated it would be superseded by PR #1093. The pull request was closed without merging.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#1093 (confidence 99%)

    Merged replacement implementing the intended fix for LP #1657504.

Related issues

Issue Project State Summary Similarity
#1112 core: setup core to support classic confinement. snapcraft merged Merged PR #1112 (49b39ef9a) added SNAPCRAFT_SETUP_CORE, fetching and unsquashing core into expected paths for classic-confinement builds on non-Snappy CI hosts.
78%
#1647422 Support classic confinement snapcraft (launchpad) closed Classic confinement support was implemented and merged in snapcore/snapcraft#946 via commit 97af16ffe, resolving launchpad/snapcraft#1647422.
78%
#946 meta: support classic confinment snapcraft merged Merged snapcraft#946 via commit 97af16ffe added classic confinement metadata support, allowing meta snaps to declare confinement as classic (LP #1647422).
73%
#1791938 Support classic when using bases snapcraft (launchpad) closed Classic confinement with base was implemented by merged PR snapcore/snapcraft#2261, commit 8096c17b3, which injects the base into classic builds.
73%
#1662351 Support ci builds when classic confinement is set snapcraft (launchpad) closed Classic-confinement CI support was implemented by provisioning the base core in snapcore/snapcraft PR #1112, commit 49b39ef9a.
73%
#1094 core: switch to using rpath for clasic confinement. snapcraft merged Merged PR #1094 (commit e174e46e6) switched core classic confinement from RUNPATH to RPATH, addressing LP #1657504.
72%
#1025 project loader: better error message for classic snapcraft merged Merged PR #1025 as commit bfe41e68c, clarifying the project-loader error when classic confinement requires a core snap that is missing.
71%
#1647699 Support classic building in snapcraft snapcraft (launchpad) closed Classic-snap builds were implemented by merged snapcore/snapcraft#949 (commit 058f5626d), resolving libraries from the core/base snap.
71%
#1665081 building a classic snap does'nt remove /snap/core/current snapcraft (launchpad) closed Closed without a code fix; the maintainer clarified that SNAPCRAFT_SETUP_CLASSIC=1 is only intended for CI use.
70%