← Back to issue list

Ignore .tox directories when creating cleanbuild tar

View original Github issue

Metadata

Project
snapcraft
Number
#1098
Type
pull request
State
closed
Author
OddBloke
Labels
—
Created
Updated
Closed

Current evaluation

PR #1098 was closed unmerged: maintainers rejected hardcoding a .tox exclusion and redirected the broader ignore-file design to LP bug #1661064.

Resolution: closed superseded

Reason: On 2017-02-07, @kyrofa closed the PR after calling the hardcoded approach non-scalable and advised implementing a general .snapcraft_ignore in LP bug #1661064 instead.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Thanks for helping us make a better Snapcraft! Checklist: - Have you signed the contributor licence agreement? https://www.ubuntu.com/legal/contributors I'm a Canonical employee. - Is there a reported a bug for the problem you are fixing? LP: [#1661064](https://bugs.launchpad.net/snapcraft/+bug/1661064) - Have you read our contribution guide? [CONTRIBUTING.md](CONTRIBUTING.md) Yes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #1098 was closed unmerged: maintainers rejected hardcoding a .tox exclusion and redirected the broader ignore-file design to LP bug #1661064.
stealth/space-bunny-alpha — closed not a bug PR #1098 proposed excluding .tox directories from cleanbuild tar archives but was closed unmerged after maintainers called the hardcoded approach non-scalable.
qwen/qwen3.6-35b-a3b — — Closed without merging. Maintainers rejected the hardcoded .tox exclusion as non-scalable. The PR was closed in favor of a broader .snapcraft_ignore feature discussed in the linked bug report.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The .tox exclusion was rejected as non-scalable. Maintainers superseded it with a broader .snapcraft_ignore feature discussed in the linked bug. Author invited to contribute to the new implementation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1661064 cleanbuild should support ignoring things in its tarball snapcraft (launchpad) closed Closed as obsolete after bases/build environments replaced the old LXD cleanbuild design; hardcoded .tox exclusion PR #1098 was closed unmerged.
81%