← Back to issue list

parser: use the project loader code to find the origin's snapcraft.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#1141
Type
pull request
State
merged
Author
josepht
Labels
—
Created
Updated
Closed

Current evaluation

Merged parser changes to use project_loader for snapcraft.yaml discovery, replacing custom origin detection and resolving LP #1665007 in commit ef34c2d3d.

Resolution: closed resolved

Reason: Pull request snapcraft#1141 was approved and merged. Commit ef34c2d3d replaced the parser's custom snapcraft.yaml lookup with the existing project_loader implementation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Rather than roll our own snapcraft.yaml logic use the existing code in project_loader. LP: #1665007

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged parser changes to use project_loader for snapcraft.yaml discovery, replacing custom origin detection and resolving LP #1665007 in commit ef34c2d3d.
stealth/space-bunny-alpha — closed resolved Merged as commit ef34c2d3d: the parser now reuses project_loader to locate the origin snapcraft.yaml instead of custom detection code, fixing LP bug #1665007.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1141 (commit ef34c2d3d), replacing custom snapcraft.yaml detection with project_loader and resolving LP #1665007.
qwen/qwen3.6-35b-a3b — — Merged a refactor replacing custom snapcraft.yaml detection with existing project_loader code, resolving LP bug #1665007. The author addressed reviewer feedback on commit formatting and conventions before final approval.
qwen3.6-35b-a3b-mtp-q6 — — Merged after addressing commit message formatting conventions. Replaced custom snapcraft.yaml discovery logic with existing project_loader code to standardize parsing and improve maintainability.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1665007 The parser needs to support origins with snap/snapcraft.yaml snapcraft (launchpad) closed Parser now finds the origin's snapcraft.yaml via the project loader, adding snap/snapcraft.yaml support. Fixed upstream by merged PR snapcore/snapcraft#1141 (commit ef34c2d3d), which closed LP bug #1665007.
84%