parser: use the project loader code to find the origin's snapcraft.yaml
Metadata
Current evaluation
Merged a refactor replacing custom snapcraft.yaml detection with existing project_loader code, resolving LP bug #1665007. The author addressed reviewer feedback on commit formatting and conventions before final approval.
Suggested action: —
No scores available.
Issue body
Rather than roll our own snapcraft.yaml logic use the existing code in project_loader.
LP: #1665007
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor replacing custom snapcraft.yaml detection with existing project_loader code, resolving LP bug #1665007. The author addressed reviewer feedback on commit formatting and conventions before final approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after addressing commit message formatting conventions. Replaced custom snapcraft.yaml discovery logic with existing project_loader code to standardize parsing and improve maintainability. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaced custom snapcraft.yaml discovery logic with existing project_loader code to resolve LP #1665007. Commit message formatting and directory structure adjustments were applied per reviewer feedback. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #773 parser - Handle project name and version variables | snapcraft | merged | Merged. Replaces $SNAPCRAFT_PROJECT_VERSION and $SNAPCRAFT_PROJECT_NAME with values from the origin snapcraft.yaml in remote parts, addressing LP:#1619418. Changes span 4 files with 86 additions and 27 deletions. | |
| #2160 many: refactor snapcraft.yaml loading out of load_config | snapcraft | merged | Merged a refactor separating raw snapcraft.yaml loading from validated processing within load_config. Approved by reviewer, passed CI checks, and integrated into master with 95.54% diff coverage. | |
| #2250 project_loader: add preflight check | snapcraft | merged | Merged. Adds a preflight check to validate snap directory contents, resolving LP #1791368. Implementation refactored into snapcraft.project as project sanity checks, retained in cli.lifecycle. Approved and merged after code review. | |
| #2744 project_loader: load build-environment after snapcraft environment | snapcraft | merged | Merged fix to load the build-environment after the snapcraft environment, enabling access to internal variables like $SNAPCRAFT_PART_INSTALL. The change swaps the evaluation order in the project loader and was approved by maintainers. | |
| #3414 project loader: export SNAPCRAFT_TARGET_ARCH in build environment | snapcraft | merged | Exported SNAPCRAFT_TARGET_ARCH in the build environment. Merged after single reviewer approval, modifying two files with six additions and two deletions. |