← Back to issue list

kernel plugin: rework MAKEFLAGS from the environment

View original Github issue

Metadata

Project
snapcraft
Number
#1150
Type
pull request
State
merged
Author
piso77
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1150 as commit 1409ed25c, removing MAKEFLAGS from the kernel plugin build environment to prevent conflicts in nested Linux Makefile builds.

Resolution: closed resolved

Reason: The approved PR was merged as commit 1409ed25c, fixing LP #1665661 by clearing the inherited MAKEFLAGS variable before invoking the kernel Makefile.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Linux's kernel Makefile gets confused if it is invoked with the environment already setup by another Linux's Makefile: linux/package/Makefile -> snapcraft -> linux/Makefile fix the problem removing the offending make variable (MAKEFLAGS) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1665661

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1150 as commit 1409ed25c, removing MAKEFLAGS from the kernel plugin build environment to prevent conflicts in nested Linux Makefile builds.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#1150 (1409ed25c), removing MAKEFLAGS from the kernel plugin build environment to prevent nested Linux Makefile conflicts; addresses LP #1665661.
qwen/qwen3.6-35b-a3b — — Merged. The kernel plugin now strips the MAKEFLAGS environment variable to prevent nested Makefile conflicts. Approved by a reviewer, passes CI, and resolves LP #1665661.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix to remove the MAKEFLAGS environment variable in the kernel plugin. This prevents the Linux kernel Makefile from misinterpreting inherited flags when called via snapcraft, resolving LP: #1665661.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1665661 (confidence 99%)

    Launchpad bug #1665661 tracked the nested Linux Makefile failure resolved by this merged PR.

Related issues

Issue Project State Summary Similarity
#1665661 kernel plugin: remove MAKEFLAGS from the environment snapcraft (launchpad) closed Fixed by merged PR canonical/snapcraft#1150 (commit 1409ed25c), removing MAKEFLAGS from the kernel plugin build environment to prevent nested Linux Makefile conflicts.
89%