kernel plugin: rework MAKEFLAGS from the environment
Metadata
Current evaluation
Merged. The kernel plugin now strips the MAKEFLAGS environment variable to prevent nested Makefile conflicts. Approved by a reviewer, passes CI, and resolves LP #1665661.
Suggested action: —
No scores available.
Issue body
Linux's kernel Makefile gets confused if it is invoked with the
environment already setup by another Linux's Makefile:
linux/package/Makefile -> snapcraft -> linux/Makefile
fix the problem removing the offending make variable (MAKEFLAGS)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
LP: #1665661
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. The kernel plugin now strips the MAKEFLAGS environment variable to prevent nested Makefile conflicts. Approved by a reviewer, passes CI, and resolves LP #1665661. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to remove the MAKEFLAGS environment variable in the kernel plugin. This prevents the Linux kernel Makefile from misinterpreting inherited flags when called via snapcraft, resolving LP: #1665661. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix removing the MAKEFLAGS environment variable from the kernel plugin to prevent Makefile confusion during snapcraft builds. Resolves LP: #1665661. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1665661 kernel plugin: remove MAKEFLAGS from the environment | snapcraft (launchpad) | closed | Closed without resolution or merge. The proposed fix to remove MAKEFLAGS from the environment was abandoned. | |
| #1242 kernel_plugin: use CROSS_COMPILE to override the default toolchain | snapcraft | merged | Merged. Enables kernel plugin toolchain override via CROSS_COMPILE. A unit test replaced the requested manual test to verify the override. A maintainer applied a minor environment variable fix prior to merge. (+17/-2 lines, 2 files) | |
| #4116 plugins: kernel: remove use of deprecated config.common.ports config | snapcraft | merged | Merged removal of deprecated config.common.ports usage from the Ubuntu kernel plugin to prevent future build failures. Approved by reviewers, passed CI, and modified 3 files. | |
| #837 kernel plugin: allow collecting the same mod deps | snapcraft | merged | Merged kernel plugin fix eliminating duplicate module dependencies via set conversion. Approved by one reviewer. Modifies two files: +36/-1 lines. |