tests: Fix name registration window limit test to latest changes
Metadata
Current evaluation
PR #1166 (adapt name-registration window-limit test) sat pending review for weeks and was closed unmerged by come-maiz on 2017-03-29 in favor of snapcraft#1224, which landed as commit c76e66be5.
Resolution: closed superseded
Reason: Maintainer come-maiz closed the PR with the comment 'Closing in favor of #1224'. PR #1224 was subsequently merged as commit c76e66be5 ('tests: update name registration window limit test.'), adopting the retry/wait approach discussed in review and splitting the store suite to avoid Travis timeouts.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #1166 (adapt name-registration window-limit test) sat pending review for weeks and was closed unmerged by come-maiz on 2017-03-29 in favor of snapcraft#1224, which landed as commit c76e66be5. | |
| stealth/space-bunny-alpha | — | closed superseded | PR #1166 updated the name registration window-limit integration test but stalled; closed 2017-03-29 in favor of #1224, which was merged as commit c76e66be5 and also split the store suite. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as superseded by snapcraft#1224, which updated the name-registration window-limit tests and split the store suite to avoid timeouts. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and superseded by #1224. Contributors discussed improving the name registration limit test to prevent blocking, suggesting retry logic and counters. The author deferred to priority work, and the branch was closed in favor of the alternative PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed in favor of PR #1224. The changes updated an integration test for new name registration window limits, but discussions highlighted test blocking issues. The work was ultimately superseded by another branch. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#1224
(confidence 98%)
Explicitly cited in the closing comment and merged as commit c76e66be5, carrying out the same test fix plus store-suite splitting.
-
Related To:
canonical/snapcraft#1224
(confidence 70%)
The merged PR also addresses LP #1676725 and implements the retry-on-429/Retry-After waiting strategy proposed in this PR's review discussion.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1224 tests: update name registration window limit test. | snapcraft | merged | Merged in c76e66be5: updated name-registration window-limit tests and split the store integration suite to avoid Travis timeouts, addressing LP #1676725. | |
| #1676725 staging integration tests for registration are failing | snapcraft (launchpad) | closed | Resolved by updating store registration-window tests for the 10-names-per-10-minutes rule in snapcraft PR #1224 (commit c76e66be5). |